Issue 31811: async and await missing from keyword list in lexical analysis doc (original) (raw)
Created on 2017-10-18 15:32 by Colin Dunklau, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 4140 | merged | tomfloyer,2017-10-26 18:07 |
| Messages (7) | ||
|---|---|---|
| msg304583 - (view) | Author: Colin Dunklau (Colin Dunklau) | Date: 2017-10-18 15:32 |
| I see that code making async/await real keywords has been merged, but it looks like Doc/reference/lexical_analysis.rst doesn't have those added https://github.com/python/cpython/blob/4a2d00c/Doc/reference/lexical_analysis.rst#keywords Is that list autogenerated somehow or was it just overlooked? | ||
| msg304618 - (view) | Author: F. Lamar (F. Lamar) | Date: 2017-10-19 12:58 |
| I a new contributor. This seems like a simple fix. I'd be happy to work on it. I will submit ar PR on or before 10-22-17 | ||
| msg304672 - (view) | Author: Yury Selivanov (yselivanov) *  |
Date: 2017-10-20 19:15 |
| They are covered here: https://github.com/python/cpython/blob/4a2d00cb4525fcb3209f04531472ba6a359ed418/Doc/reference/compound_stmts.rst#coroutines | ||
| msg304686 - (view) | Author: Colin Dunklau (Colin Dunklau) | Date: 2017-10-20 22:37 |
| Hi Yury, perhaps I've misinterpreted PEP 492, and I can't claim to understand how the parser works and thus how the changes in https://github.com/python/cpython/pull/1669 affect things, but it seems to me that async and await are truly reserved words now, not just only reserved in certain contexts. If that's true, shouldn't they also appear in the list in the lexical analysis doc? I'd appreciate any clarification you (or anyone else) can offer. | ||
| msg304687 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2017-10-20 22:52 |
| Ah, you mean this list: https://docs.python.org/3/reference/lexical_analysis.html#keywords ? Your original link was a bit hard to read as it shows rest markup and not the actual list of keywords. So I missed it, sorry. I'll reopen the issue, please feel free to submit a PR! | ||
| msg305077 - (view) | Author: Tom Floyer (tomfloyer) * | Date: 2017-10-26 18:07 |
| I've added those keywords to documentation master branch. | ||
| msg305885 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-11-08 17:43 |
| The final commit uses the wrong bpo number: New changeset bf9d317626eebcf79bd0756b4dd43df82d5cc186 by Yury Selivanov (Tom Floyer) in branch 'master': bpo-31810: added missing keywords to docs. (#4140) https://github.com/python/cpython/commit/bf9d317626eebcf79bd0756b4dd43df82d5cc186 |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:53 | admin | set | github: 75992 |
| 2017-11-08 17:43:42 | vstinner | set | nosy: + vstinnermessages: + |
| 2017-11-08 17:31:51 | yselivanov | set | status: open -> closedresolution: fixedstage: patch review -> resolved |
| 2017-11-08 08:54:42 | tomfloyer | set | pull_requests: - <pull%5Frequest4095> |
| 2017-10-26 18:07:17 | tomfloyer | set | nosy: + tomfloyermessages: + pull_requests: + <pull%5Frequest4104> |
| 2017-10-26 13:09:44 | tomfloyer | set | keywords: + patchstage: needs patch -> patch reviewpull_requests: + <pull%5Frequest4095> |
| 2017-10-20 22:52:34 | yselivanov | set | status: closed -> openresolution: not a bug -> (no value)messages: + stage: resolved -> needs patch |
| 2017-10-20 22:37:05 | Colin Dunklau | set | messages: + |
| 2017-10-20 19:15:44 | yselivanov | set | status: open -> closedresolution: not a bugmessages: + stage: resolved |
| 2017-10-20 18:53:35 | terry.reedy | set | nosy: + yselivanov |
| 2017-10-19 12:58:41 | F. Lamar | set | nosy: + F. Lamarmessages: + |
| 2017-10-18 15:32:03 | Colin Dunklau | create |