Issue 31921: Bring together logic for entering/leaving a frame in frameobject.c (original) (raw)

Issue31921

Created on 2017-11-02 09:56 by pdox, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 4226 closed pdox,2017-11-02 10:00
Messages (3)
msg305408 - (view) Author: (pdox) * Date: 2017-11-02 09:56
This is a refactor to move all the code involved in entering a frame (making it the active frame for the current tstate) and leaving a frame (removing it as an active frame, possibly destructing it or making it GC tracked) into private functions in frameobject.c. The underlying goal of this change is to make it possible to add (as a performance feature) stack-allocated frames, in addition to the usual heap-allocated ones.
msg305460 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2017-11-03 03:22
I don't think we should be re-arranging the core of the language to facilitate your language experiments. We need to know that is this is valuable for other people, not just you.
msg305590 - (view) Author: (pdox) * Date: 2017-11-05 10:51
Raymond, this is not an experiment, but the beginning of a sustained effort to improve locality during execution, to make more effective use of CPU cache lines. Rather than discuss the details of this change one PR at a time, I will close this issue for now, and open a discussion on python-dev.
History
Date User Action Args
2022-04-11 14:58:53 admin set github: 76102
2017-11-05 10:51:52 pdox set resolution: rejected
2017-11-05 10:51:18 pdox set status: open -> closedmessages: + stage: patch review -> resolved
2017-11-03 03:22:07 rhettinger set nosy: + rhettingermessages: +
2017-11-02 10:00:47 pdox set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest4195>
2017-11-02 09:56:19 pdox create