Issue 31985: Deprecate openfp() in aifc, sunau and wave (original) (raw)

Created on 2017-11-08 21:56 by brian.curtin, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 4344 merged brian.curtin,2017-11-08 22:05
Messages (8)
msg305912 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2017-11-08 21:56
Since 1993, aifc.openfp has simply pointed to aifc.open as a matter of backwards compatibility. See https://github.com/python/cpython/commit/7bc817d5ba917528e8bd07ec461c635291e7b06a for the exact change. aifc.openfp is both undocumented and untested, and in looking at doc coverage I decided it's better to deprecate it since it's silently been there for 25 years.
msg305917 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-11-08 22:41
Don't forget about wave and sunau. You can use a common test for all three modules.
msg305924 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2017-11-09 00:18
i was going to do them as separate bugs and PRs per module, but if one is fine then i can do that. Updating the title as well since nothing is beings removed (was originally going to suggest skipping to removal but won’t do that).
msg305989 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2017-11-09 22:04
Serhiy, where should a common test that covers all three of these go? I'm not seeing an obvious place for it.
msg305995 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-11-09 23:03
audiotests.py. Create class AudioMiscTests and inherit classes AifcMiscTest, SunauMiscTest, WaveMiscTest from it instead of AudioTests. There is more work because there was no base for misc tests, but this will make adding other common misc test easier.
msg305999 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2017-11-09 23:46
I think https://github.com/python/cpython/pull/4344 covers what you're looking for.
msg306038 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2017-11-10 16:38
New changeset 9f914a01affc55abe799afc521ce71612bb495a5 by Brian Curtin in branch 'master': bpo-31985: Deprecate openfp in aifc, sunau, and wave (#4344) https://github.com/python/cpython/commit/9f914a01affc55abe799afc521ce71612bb495a5
msg345896 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-06-17 20:12
I created bpo-37320: "aifc, sunau, wave: remove deprecated openfp() function".
History
Date User Action Args
2022-04-11 14:58:54 admin set github: 76166
2019-06-17 20:12:59 vstinner set status: open -> closednosy: + vstinnermessages: + resolution: fixedstage: patch review -> resolved
2017-11-10 16:38:28 brian.curtin set messages: +
2017-11-09 23:46:08 brian.curtin set messages: +
2017-11-09 23:03:32 serhiy.storchaka set messages: +
2017-11-09 22:04:05 brian.curtin set messages: +
2017-11-09 22:01:13 serhiy.storchaka set title: Deprecate aifc.openfp -> Deprecate openfp() in aifc, sunau and wave
2017-11-09 00🔞21 brian.curtin set messages: + title: Deprecate/remove aifc.openfp -> Deprecate aifc.openfp
2017-11-08 22:41:24 serhiy.storchaka set nosy: + serhiy.storchakamessages: +
2017-11-08 22:05:04 brian.curtin set keywords: + patchstage: needs patch -> patch reviewpull_requests: + <pull%5Frequest4302>
2017-11-08 21:56:36 brian.curtin create