Issue 32077: Documentation: Some Unicode object functions don't indicate whether they return a new reference (original) (raw)
Created on 2017-11-20 00:00 by Mathew M., last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 4472 | closed | Mathew M.,2017-11-20 00:06 | |
| PR 11243 | merged | Mathew M.,2018-12-19 17:02 | |
| PR 11245 | merged | miss-islington,2018-12-19 19:13 | |
| PR 11246 | closed | miss-islington,2018-12-19 19:13 |
| Messages (6) | ||
|---|---|---|
| msg306516 - (view) | Author: Mathew M. (Mathew M.) * | Date: 2017-11-20 00:00 |
| This is just something I've noticed when browsing the C API documentation for Unicode objects. For example, the documentation entry for PyUnicode_DecodeMBCSStateful lacks the "Return value: New reference", etc. | ||
| msg306518 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2017-11-20 00:08 |
| C API functions return new references by default. It needs to be explicitly documented only when the function returns a borrowed reference. | ||
| msg306519 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2017-11-20 00:11 |
| Ah, you have changed just refcounts.dat! This is good. | ||
| msg332161 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-12-19 19:13 |
| New changeset b2f642ccd2f65d2f3bf77bbaa103dd2bc2733734 by Serhiy Storchaka (Mat M) in branch 'master': bpo-32077: Update refcounts.dat for Unicode object functions. (GH-11243) https://github.com/python/cpython/commit/b2f642ccd2f65d2f3bf77bbaa103dd2bc2733734 | ||
| msg332162 - (view) | Author: miss-islington (miss-islington) | Date: 2018-12-19 20:03 |
| New changeset 29d4e309b1b4dfb26d65d83c683002911c066dec by Miss Islington (bot) in branch '3.7': bpo-32077: Update refcounts.dat for Unicode object functions. (GH-11243) https://github.com/python/cpython/commit/29d4e309b1b4dfb26d65d83c683002911c066dec | ||
| msg332163 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-12-19 20:13 |
| Sorry, I forget about this issue and remembered it only after creating similar patch from scratch. PR 11247 is what left from it after merging your patch. |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:54 | admin | set | github: 76258 |
| 2018-12-19 20:13:42 | serhiy.storchaka | set | status: open -> closedversions: + Python 3.6, Python 3.7, Python 3.8messages: + resolution: fixedstage: patch review -> resolved |
| 2018-12-19 20:03:25 | miss-islington | set | nosy: + miss-islingtonmessages: + |
| 2018-12-19 19:13:33 | miss-islington | set | pull_requests: + <pull%5Frequest10475> |
| 2018-12-19 19:13:27 | miss-islington | set | pull_requests: + <pull%5Frequest10474> |
| 2018-12-19 19:13:25 | serhiy.storchaka | set | messages: + |
| 2018-12-19 17:02:23 | Mathew M. | set | pull_requests: + <pull%5Frequest10473> |
| 2017-11-20 00:11:06 | serhiy.storchaka | set | messages: + |
| 2017-11-20 00:08:09 | serhiy.storchaka | set | nosy: + serhiy.storchakamessages: + |
| 2017-11-20 00:06:25 | Mathew M. | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest4407> |
| 2017-11-20 00:00:14 | Mathew M. | create |