Issue 32639: Coverity: CID 1428443: Null pointer dereferences (NULL_RETURNS) /Python/hamt.c: 1058 in hamt_node_bitmap_without() (original) (raw)

Issue32639

Created on 2018-01-23 20:58 by vstinner, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (4)
msg310522 - (view)	Author: STINNER Victor (vstinner) *	Date: 2018-01-23 20:58
Coverity found a bug in hamt.c: ** CID 1428443: Null pointer dereferences (NULL_RETURNS) /Python/hamt.c: 1058 in hamt_node_bitmap_without() ________________________________________________________________________________________________________ *** CID 1428443: Null pointer dereferences (NULL_RETURNS) /Python/hamt.c: 1058 in hamt_node_bitmap_without() 1052 assert(hamt_node_collision_count( 1053 (PyHamtNode_Collision*)sub_node) > 1); 1054 } 1055 #endif 1056 1057 PyHamtNode_Bitmap *clone = hamt_node_bitmap_clone(self); >>> CID 1428443: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a null pointer "clone". 1058 Py_SETREF(clone->b_array[val_idx], 1059 (PyObject *)sub_node); /* borrow */ 1060 1061 *new_node = (PyHamtNode *)clone; 1062 return W_NEWNODE; 1063 }
msg310524 - (view)	Author: Yury Selivanov (yselivanov) *	Date: 2018-01-23 21:26
Victor, it's been already fixed/tracked here: https://github.com/python/cpython/pull/5286 (I also receive coverity reports :)
msg310526 - (view)	Author: STINNER Victor (vstinner) *	Date: 2018-01-23 21:33
> (I also receive coverity reports :) Oh, I didn't know. The current workflow is not ideal to avoid duplicated issues.
msg310527 - (view)	Author: Yury Selivanov (yselivanov) *	Date: 2018-01-23 21:47
> Oh, I didn't know. The current workflow is not ideal to avoid duplicated issues. If I fix something that's been reported there I usually update the coverity issue directly. But yeah...