Issue 32681: Fix uninitialized variable in os_dup2_impl (original) (raw)

Issue32681

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/76862

classification

process

Created on 2018-01-26 15:34 by matrixise, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (4)
msg310767 - (view)	Author: Stéphane Wirtel (matrixise) *	Date: 2018-01-26 15:34
With the last revision, I get this warning from the compiler. gcc -pthread -Wno-unused-result -Wsign-compare -g -Og -Wall -Wstrict-prototypes -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Werror=implicit-function-declaration -I. -I./Include -DPy_BUILD_CORE -c ./Modules/_collectionsmodule.c -o Modules/_collectionsmodule.o ./Modules/posixmodule.c: In function ‘os_dup2_impl’: ./Modules/posixmodule.c:7785:9: warning: ‘res’ may be used uninitialized in this function [-Wmaybe-uninitialized] int res; ^~~
msg310768 - (view)	Author: STINNER Victor (vstinner) *	Date: 2018-01-26 15:35
I already reported the issue at: https://bugs.python.org/issue32441#msg310752 I suggest to close this issue as a duplicate.
msg310772 - (view)	Author: Stéphane Wirtel (matrixise) *	Date: 2018-01-26 15:51
Yes, you can close it, but I don't understand why there is no fix for this warning. my issue has a small PR, but the other issue on b.p.o, I am not really sure about my fix... I just set the 'res' variable to 0 and avoid this kind of message. Is there an other way if I want to fix it ?
msg311238 - (view)	Author: Gregory P. Smith (gregory.p.smith) *	Date: 2018-01-30 06:04
New changeset 3d86e484de6334fe16cbab512744597bd0de4e80 by Gregory P. Smith (Stéphane Wirtel) in branch 'master': bpo-32681: Fix an uninitialized variable in the C implementation of os.dup2 (GH-5346) https://github.com/python/cpython/commit/3d86e484de6334fe16cbab512744597bd0de4e80