Issue 32963: Python 2.7 tutorial claims source code is UTF-8 encoded (original) (raw)
Created on 2018-02-27 09:04 by mjpieters, last changed 2022-04-11 14:58 by admin. This issue is now closed.
Pull Requests | |||
---|---|---|---|
URL | Status | Linked | Edit |
PR 5961 | merged | brett.cannon,2018-03-02 22:03 |
Messages (8) | ||
---|---|---|
msg312986 - (view) | Author: Martijn Pieters (mjpieters) * | Date: 2018-02-27 09:04 |
Issue #29381 updated the tutorial to clarify #! use, but the 2.7 patch re-used Python 3 material that doesn't apply. See r40ba60f6 at https://github.com/python/cpython/commit/40ba60f6bf2f7192f86da395c71348d0fa24da09 It now reads: "By default, Python source files are treated as encoded in UTF-8." and " To display all these characters properly, your editor must recognize that the file is UTF-8, and it must use a font that supports all the characters in the file." This is a huge deviation from the previous text, and confusing and wrong to people new to Python 2. | ||
msg313076 - (view) | Author: Brett Cannon (brett.cannon) * ![]() |
Date: 2018-03-01 00:11 |
https://docs.python.org/2.7/tutorial/interpreter.html#source-code-encoding if people are looking for the doc link. | ||
msg313157 - (view) | Author: Brett Cannon (brett.cannon) * ![]() |
Date: 2018-03-02 19:19 |
If no one gets to this before the sprints at PyCon US I will take care of it, but anyone can feel free to submit a pull request to fix this. | ||
msg313158 - (view) | Author: Mariatta (Mariatta) * ![]() |
Date: 2018-03-02 19:39 |
I'm not intending to work on this, nothing until after PyCon :) Feel free to pick it up. | ||
msg313166 - (view) | Author: Brett Cannon (brett.cannon) * ![]() |
Date: 2018-03-02 22:10 |
New changeset 20003f9162631c47b79202316036d13d74484e4c by Brett Cannon in branch '2.7': bpo-32963: Fix the tutorial to state source has a default encoding of ASCII (GH-5961) https://github.com/python/cpython/commit/20003f9162631c47b79202316036d13d74484e4c | ||
msg313167 - (view) | Author: Brett Cannon (brett.cannon) * ![]() |
Date: 2018-03-02 22:10 |
Thanks for the bug report, Martijn! | ||
msg313184 - (view) | Author: Martijn Pieters (mjpieters) * | Date: 2018-03-03 11:53 |
Thanks for the quick fix, sorry I didn't have a PR for this one! | ||
msg313193 - (view) | Author: Brett Cannon (brett.cannon) * ![]() |
Date: 2018-03-03 19:00 |
No need to apologize! We all only have so much free time. |
History | |||
---|---|---|---|
Date | User | Action | Args |
2022-04-11 14:58:58 | admin | set | github: 77144 |
2018-03-03 19:00:27 | brett.cannon | set | messages: + |
2018-03-03 11:53:46 | mjpieters | set | messages: + |
2018-03-02 22:10:52 | brett.cannon | set | status: open -> closedmessages: + keywords: - patchresolution: fixedstage: patch review -> resolved |
2018-03-02 22:10:23 | brett.cannon | set | messages: + |
2018-03-02 22:03:34 | brett.cannon | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest5729> |
2018-03-02 19:39:22 | Mariatta | set | messages: + |
2018-03-02 19:19:44 | brett.cannon | set | keywords: + easyassignee: docs@python -> brett.cannonmessages: + |
2018-03-01 00:11:02 | brett.cannon | set | nosy: + brett.cannonmessages: + |
2018-02-27 09:05:04 | mjpieters | set | nosy: + rhettinger, Mariatta |
2018-02-27 09:04:23 | mjpieters | create |