Issue 32964: Reuse a testing implementation of the path protocol in tests (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/77145

classification

Title: Reuse a testing implementation of the path protocol in tests
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.8, Python 3.7, Python 3.6

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: brett.cannon, ezio.melotti, miss-islington, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2018-02-27 19:40 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 5930 merged serhiy.storchaka,2018-02-27 19:42
PR 5957 merged miss-islington,2018-03-02 09:54
PR 5958 merged serhiy.storchaka,2018-03-02 10:07
Messages (5)
msg313018 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-02-27 19:40
In a number of tests there are simple implementations of the path protocol. Unlike to pathlib.Path they implement only necessary minimum of methods. The proposed PR moves this implementation into test.support. It also fixes some misuses of it. I have named it SimplePath. Are there better ideas? PathLike was rejected due to possible confusion with os.PathLike.
msg313067 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2018-02-28 19:56
FakePath? Otherwise SimplePath seems as good a name as any other one.
msg313128 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-03-02 09:53
New changeset b21d155f57d284aecf9092a9bd24258293965c2f by Serhiy Storchaka in branch 'master': bpo-32964: Reuse a testing implementation of the path protocol in tests. (#5930) https://github.com/python/cpython/commit/b21d155f57d284aecf9092a9bd24258293965c2f
msg313129 - (view) Author: miss-islington (miss-islington) Date: 2018-03-02 10:17
New changeset a13b65422a1078104e9f53ad41945ea380a80798 by Miss Islington (bot) in branch '3.7': bpo-32964: Reuse a testing implementation of the path protocol in tests. (GH-5930) https://github.com/python/cpython/commit/a13b65422a1078104e9f53ad41945ea380a80798
msg313186 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-03-03 12:19
New changeset fbdd075c64a5229dfa26632cf1b2cf2361dc5003 by Serhiy Storchaka in branch '3.6': [3.6] bpo-32964: Reuse a testing implementation of the path protocol in tests. (GH-5930). (GH-5958) https://github.com/python/cpython/commit/fbdd075c64a5229dfa26632cf1b2cf2361dc5003
History
Date User Action Args
2022-04-11 14:58:58 admin set github: 77145
2018-03-03 12:19:54 serhiy.storchaka set status: open -> closedresolution: fixedstage: patch review -> resolved
2018-03-03 12:19:32 serhiy.storchaka set messages: +
2018-03-02 10:17:56 miss-islington set nosy: + miss-islingtonmessages: +
2018-03-02 10:07:12 serhiy.storchaka set pull_requests: + <pull%5Frequest5725>
2018-03-02 09:54:11 miss-islington set pull_requests: + <pull%5Frequest5724>
2018-03-02 09:53:59 serhiy.storchaka set messages: +
2018-02-28 19:56:58 brett.cannon set messages: +
2018-02-27 19:42:16 serhiy.storchaka set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest5702>
2018-02-27 19:40:07 serhiy.storchaka create