Issue 33135: Define field prefixes for the various config structs (original) (raw)

Created on 2018-03-25 06:10 by ncoghlan, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (5)
msg314398 - (view) Author: Alyssa Coghlan (ncoghlan) * (Python committer) Date: 2018-03-25 06:10
While working on https://bugs.python.org/issue33042, I found it hard to keep track of which kind of config struct a particular piece of code was referencing. As a particularly relevant example, we currently have 3 different "warnoptions" fields: the private-to-main one for reading the command line settings, the "wchar_t *" list in the core config, and the "PyObject *" list object in the main interpreter config (which is also the one aliased as sys.warnoptions). What do you think of adopting a convention where: * the command line fields all gain a "cmd_" prefix * the core config fields all gain a "c_" prefix * the interpreter config fields all gain a "py_" prefix We'd then have "cmd_warnoptions", "c_warnoptions", and "py_warnoptions" as the field names, and it would be more self-evident which layer we were working at in any particular piece of code.
msg342562 - (view) Author: Batuhan Taskaya (BTaskaya) * (Python committer) Date: 2019-05-15 11:17
+1 from me. But i dont understand why this issue triaged as "needs patch". Isn't it should be discussed first?
msg342574 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-05-15 14:19
In the master branch, the C function config_read_cmdline() uses: * cmdline_warnoptions: -W command line arguments * env_warnoptions: PYTHONWARNINGS environment variable The config_init_warnoptions() uses these 2 list and combine it with other options, dev_mode and bytes_warnings. The warnings options are now specified in my PEP 587: https://www.python.org/dev/peps/pep-0587/#priority-and-rules
msg343646 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-05-27 15:31
> As a particularly relevant example, we currently have 3 different "warnoptions" fields: the private-to-main one for reading the command line settings, the "wchar_t *" list in the core config, and the "PyObject *" list object in the main interpreter config (which is also the one aliased as sys.warnoptions). This issue has been fixed in bpo-36763 with the implementation of the PEP 587. PyConfig.warnoptions is now an unified list of warnings options. Moreover, the priority of warnings options is now defined at: https://www.python.org/dev/peps/pep-0587/#priority-and-rules
msg353519 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-09-30 00:30
(Oops, I posted a comment to the wrong issue, it was a comment for bpo-38317.)
History
Date User Action Args
2022-04-11 14:58:59 admin set github: 77316
2019-09-30 00:30:42 vstinner set messages: +
2019-09-30 00:30:12 vstinner set messages: -
2019-09-30 00:29:25 vstinner set messages: +
2019-05-27 15:31:08 vstinner set status: open -> closedresolution: fixedmessages: + stage: needs patch -> resolved
2019-05-15 14:19:54 vstinner set messages: +
2019-05-15 11:17:47 BTaskaya set nosy: + BTaskayamessages: +
2019-04-19 20:39:51 nanjekyejoannah set nosy: + nanjekyejoannah
2018-03-25 06:10:23 ncoghlan create