Issue 33151: importlib.resources breaks on subdirectories (original) (raw)

Issue33151

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/77332

classification

Title: importlib.resources breaks on subdirectories
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.8, Python 3.7

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: barry Nosy List: barry, brett.cannon
Priority: normal Keywords: patch

Created on 2018-03-27 04:47 by barry, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 6268 merged barry,2018-03-27 05:30
PR 6270 merged miss-islington,2018-03-27 17:00
Messages (4)
msg314500 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2018-03-27 04:47
Found a bug when trying to read a resource from a subpackage in a zip file. I was actually surprised we didn't have a test for this AFAICT, and when I added one, it did fail. I have a PR coming soon.
msg314501 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2018-03-27 05:29
is_resource() from zip submodules is also affected
msg314540 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2018-03-27 16:59
New changeset 30e507dff465a31901d87df791a2bac40dc88530 by Barry Warsaw in branch 'master': bpo-33151: Handle submodule resources (GH-6268) https://github.com/python/cpython/commit/30e507dff465a31901d87df791a2bac40dc88530
msg314542 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2018-03-27 17:25
New changeset fd1b8f87b3e63495cadd37c8f1b90191b46ee52a by Barry Warsaw (Miss Islington (bot)) in branch '3.7': bpo-33151: Handle submodule resources (GH-6268) (GH-6270) https://github.com/python/cpython/commit/fd1b8f87b3e63495cadd37c8f1b90191b46ee52a
History
Date User Action Args
2022-04-11 14:58:59 admin set github: 77332
2018-03-27 17:25:51 barry set status: open -> closedresolution: fixedstage: patch review -> resolved
2018-03-27 17:25:34 barry set messages: +
2018-03-27 17:00:05 miss-islington set pull_requests: + <pull%5Frequest5998>
2018-03-27 16:59:43 barry set messages: +
2018-03-27 05:30:49 barry set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest5993>
2018-03-27 05:29:10 barry set messages: +
2018-03-27 04:47:44 barry create

Supported by The Python Software Foundation,
Powered by Roundup

Copyright © 1990-2022, Python Software Foundation
Legal Statements