Issue 33161: Refactor of pathlib's _WindowsBehavior.gethomedir (original) (raw)

Issue33161

Created on 2018-03-28 00:47 by onlined, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 6275 closed onlined,2018-03-28 01:08
Messages (2)
msg314562 - (view) Author: Ekin Dursun (onlined) * Date: 2018-03-28 00:47
At line 245, default value for drv is provided with KeyError handling, but it is better to use dict's get method.
msg323063 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2018-08-03 18:56
Thanks for the PR, but we usually avoid unnecessary churn in Python codebase. Both versions look fine, and deciding which one to use is just a matter of personal taste.
History
Date User Action Args
2022-04-11 14:58:59 admin set github: 77342
2018-08-03 18:56:25 berker.peksag set status: open -> closedcomponents: - Windowsnosy: + berker.peksag, - paul.moore, tim.golden, zach.ware, steve.dowermessages: + resolution: rejectedstage: patch review -> resolved
2018-03-28 01:08:02 onlined set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest6002>
2018-03-28 00:47:21 onlined create