original ) (raw )Created on 2018-04-11 22:57 by adelfino , last changed 2022-04-11 14:58 by admin . This issue is now closed .
Pull Requests
URL
Status
Linked
Edit
PR 6454 merged
adelfino,2018-04-11 22:59
PR 6486 merged
miss-islington,2018-04-16 14:06
PR 6487 merged
miss-islington,2018-04-16 14:06
Messages (9)
msg315204 - (view) Author: Andrés Delfino (adelfino) *
Date: 2018-04-11 22:57
Documentation says urllib.request.urlretrieve "might become deprecated at some point in the future". IMHO, it's better to provide examples that do not make users rely on API that has this label. I propose the example in the pull request to accomplish exactly the same task while not relying on urllib.request.urlretrieve.
msg315206 - (view) Author: Senthil Kumaran (orsenthil) *
Date: 2018-04-11 23:44
Andrés, your pull request looks good to me. Please go ahead and sign the CLA and I can merge this to cpython HEAD. Thank you for your contribution.
msg315207 - (view) Author: Andrés Delfino (adelfino) *
Date: 2018-04-11 23:48
Hi Senthil! I signed the CLA several days ago. Got the "Python Contributor Agreement Form between Python Software Foundation and Andrés Delfino is Signed and Filed!" mail on April 1st (perhaps I chose a bad date to fill the request ;) )
msg315210 - (view) Author: Andrés Delfino (adelfino) *
Date: 2018-04-12 00:40
The agreement can be found at: https://secure.na1.echosign.com/public/viewAgreement?tsid=CBFCIBAA3AAABLblqZhC0bOfZxqQ_bUGhwUqnYiqqxAj3N7_dOts1qHsH9YdsbakL5qJ6FbSU9NHkecXglBLZ29gXbHeNdUErGzW7QkUs& ;
msg315237 - (view) Author: Andrés Delfino (adelfino) *
Date: 2018-04-12 23:00
My contributor form shows as received now :) Don't know how to update the "CLA not signed" label on the PR.
msg315280 - (view) Author: Terry J. Reedy (terry.reedy) *
Date: 2018-04-14 00:32
The label has been changed. Senthil, go ahead and merge this.
msg315359 - (view) Author: Senthil Kumaran (orsenthil) *
Date: 2018-04-16 14:13
Thank you, Andrés and Terry. This is merged in 3.8 and backported to 3.7 and 3.6 too.
msg315511 - (view) Author: Andrés Delfino (adelfino) *
Date: 2018-04-20 14:00
I believe this issue can be closed, right?
msg315513 - (view) Author: Senthil Kumaran (orsenthil) *
Date: 2018-04-20 14:16
Indeed. Thank you!
History
Date
User
Action
Args
2022-04-11 14:58:59
admin
set
github: 77445
2018-04-20 14:16:55
orsenthil
set
status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved
2018-04-20 14:00:14
adelfino
set
messages: +
2018-04-16 14:13:05
orsenthil
set
messages: + versions: + Python 3.6, Python 3.7
2018-04-16 14:06:44
miss-islington
set
pull_requests: + <pull%5Frequest6186>
2018-04-16 14:06:29
miss-islington
set
pull_requests: + <pull%5Frequest6185>
2018-04-14 00:32:20
terry.reedy
set
nosy: + terry.reedy messages: +
2018-04-12 23:00:55
adelfino
set
messages: +
2018-04-12 00:40:33
adelfino
set
messages: +
2018-04-11 23:48:09
adelfino
set
messages: +
2018-04-11 23:44:05
orsenthil
set
messages: +
2018-04-11 23:31:37
ned.deily
set
nosy: + orsenthil
2018-04-11 22:59:29
adelfino
set
keywords: + patch stage: patch reviewpull_requests: + <pull%5Frequest6148>
2018-04-11 22:57:04
adelfino
create
