Issue 33341: python3 fails to build if directory or sysroot contains "icc" string (original) (raw)

Created on 2018-04-23 10:12 by locutusofborg, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
icc-find.patch locutusofborg,2018-05-17 15:13
Messages (6)
msg315656 - (view) Author: Gianfranco (locutusofborg) * Date: 2018-04-23 10:12
Hello, as said, in yocto we pass in $CC environment, also the --sysroot keyword. If --sysroot contains the "*icc*" or "*gcc*" in path, the build fails because of wrong autoconf checks. checking in a case switch for *icc* seems bad to me, I propose to change it with something like "*icc" so we might exclude when icc is not the compiler. I know this isn't a strong patch, but maybe we can apply it while writing some better detect code. The build fails as descripted in the yocto bug https://bugzilla.yoctoproject.org/show_bug.cgi?id=12703
msg315805 - (view) Author: Gianfranco (locutusofborg) * Date: 2018-04-26 16:33
I signed the contributor agreement, even if such patches shouldn't need any kind of license
msg315854 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-04-27 18:52
Thank you. Yes, we require a signed CA for something this non-trivial. Victor, I don't know who maintains configure. If you don't, maybe you know who does.
msg316920 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2018-05-17 12:32
Maybe this is the same as Issue 28584, about the ${CC} variable rather than “sysroot”. In any case, the patch looks unrelated.
msg316945 - (view) Author: Gianfranco (locutusofborg) * Date: 2018-05-17 15:13
This was the patch I wanted to add, but I picked up a wrong one (a vbox one) In any case, duplicate of
msg316948 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-05-17 15:35
icc-find.patch (and a 2nd version) has been uploaded to #28584 also. I unlinked the erroneous upload 'patch'.
History
Date User Action Args
2022-04-11 14:58:59 admin set github: 77522
2018-05-19 00:38:18 vstinner set nosy: + vstinner
2018-05-19 00:37:26 vstinner set nosy: - vstinner
2018-05-17 15:35:11 terry.reedy set messages: +
2018-05-17 15:34:20 terry.reedy set files: - patch
2018-05-17 15:31:11 terry.reedy set status: open -> closedsuperseder: ICC compiler check is too permissivestage: patch review -> resolved
2018-05-17 15:13:40 locutusofborg set files: + icc-find.patchresolution: duplicatemessages: + keywords: + patch
2018-05-17 12:32:34 martin.panter set nosy: + martin.pantermessages: +
2018-04-27 18:52:07 terry.reedy set nosy: + vstinner, terry.reedymessages: + stage: patch review
2018-04-26 16:33:49 locutusofborg set messages: +
2018-04-23 10:12:22 locutusofborg create