Issue 33483: build system requires explicit compiler, but should discover it (original) (raw)

Created on 2018-05-13 18:28 by eitan.adler, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 6780 merged eitan.adler,2018-05-13 18:31
Messages (5)
msg316468 - (view) Author: Eitan Adler (eitan.adler) * Date: 2018-05-13 18:28
configure.ac requires explicit configuration for finding the preferred compiler. This results in a non-native way of configuring the system, and does not actually work on most platforms. Expected behavior: CC is used to discover the C compiler; CPP, LD, CXX, etc. are used to discover their appropriate tools Actual: --without-gcc or --with-icc must be explicitly passed
msg316569 - (view) Author: Stéphane Wirtel (matrixise) * (Python committer) Date: 2018-05-14 19:55
Do you have an example where your patch will work and not the current configure.ac. Thank you.
msg316585 - (view) Author: Eitan Adler (eitan.adler) * Date: 2018-05-14 21:44
On any system where "gcc" is not the correct compiler to use. If it does not exist, is too old, points to the incorrect compiler, etc. Concretely I have two such systems: - on one, "gcc" does not exist - on the other "gcc" is actually a hardlink to "clang"
msg316617 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-05-15 03:55
New changeset 98929b545e86e7c7296c912d8f34e8e8d3fd6439 by Benjamin Peterson (Eitan Adler) in branch 'master': bpo-33483: more correctly handle finding the C compiler (GH-6780) https://github.com/python/cpython/commit/98929b545e86e7c7296c912d8f34e8e8d3fd6439
msg378733 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2020-10-16 18:42
This seems complete, can it be closed?
History
Date User Action Args
2022-04-11 14:59:00 admin set github: 77664
2020-10-16 18:45:11 benjamin.peterson set status: open -> closedresolution: fixedstage: patch review -> resolved
2020-10-16 18:42:02 iritkatriel set nosy: + iritkatrielmessages: +
2018-05-15 03:55:43 benjamin.peterson set nosy: + benjamin.petersonmessages: +
2018-05-14 21:44:49 eitan.adler set messages: +
2018-05-14 19:55:11 matrixise set nosy: + matrixisemessages: +
2018-05-13 18:31:39 eitan.adler set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest6466>
2018-05-13 18:28:54 eitan.adler create