Issue 33549: xmlbuilder's _AsyncDeprecatedProperty make no sens now that async is a keyword. (original) (raw)
Issue33549
Created on 2018-05-16 21:33 by mbussonn, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 6924 | merged | mbussonn,2018-05-16 22:01 | |
| PR 6929 | merged | miss-islington,2018-05-17 08:16 |
| Messages (4) | ||
|---|---|---|
| msg316871 - (view) | Author: Matthias Bussonnier (mbussonn) * | Date: 2018-05-16 21:33 |
| `Lib/xml/dom/xmlbuilder's DocumentLS try to catch the use of `obj.asyc` and warn that it's now `obj.async_`. Though now that async is a proper keyword `obj.async` is anyway SyntaxError, so the warning will likely almost never be displayed. I guess one could still use getattr/setattr, but I doubt this is the most common use case this was meant to prevent. | ||
| msg316897 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2018-05-17 08:16 |
| New changeset f90f5d5c1d95721e0ca0b1c302e3d13ed34753a8 by Serhiy Storchaka (Matthias Bussonnier) in branch 'master': bpo-33549: Remove shim and deprecation warning to access DocumentLS.async. (GH-6924) https://github.com/python/cpython/commit/f90f5d5c1d95721e0ca0b1c302e3d13ed34753a8 | ||
| msg316898 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-05-17 09:01 |
| New changeset 216a27766fab59f4dfecfae0c453f7f3fd478989 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.7': bpo-33549: Remove shim and deprecation warning to access DocumentLS.async. (GH-6924) (GH-6929) https://github.com/python/cpython/commit/216a27766fab59f4dfecfae0c453f7f3fd478989 | ||
| msg316899 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-05-17 09:02 |
| Thank you Matthias! |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:00 | admin | set | github: 77730 |
| 2018-05-17 09:02:08 | serhiy.storchaka | set | status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved |
| 2018-05-17 09:01:04 | serhiy.storchaka | set | messages: + |
| 2018-05-17 08:16:22 | miss-islington | set | pull_requests: + <pull%5Frequest6600> |
| 2018-05-17 08:16:15 | serhiy.storchaka | set | nosy: + serhiy.storchakamessages: + |
| 2018-05-17 08:15:45 | serhiy.storchaka | set | components: + Library (Lib), XMLversions: + Python 3.7, Python 3.8 |
| 2018-05-16 22:01:12 | mbussonn | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest6594> |
| 2018-05-16 21:33:46 | mbussonn | create |