Issue 33556: leftover thread crumb in threading.ident docstring (original) (raw)
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/77737
classification
| Title: | leftover thread crumb in threading.ident docstring | ||
|---|---|---|---|
| Type: | Stage: | resolved | |
| Components: | Library (Lib) | Versions: | Python 3.8, Python 3.7, Python 3.6 |
process
| Status: | closed | Resolution: | fixed |
|---|---|---|---|
| Dependencies: | Superseder: | ||
| Assigned To: | Nosy List: | miss-islington, skip.montanaro, zach.ware | |
| Priority: | normal | Keywords: | easy, patch |
Created on 2018-05-17 13:53 by skip.montanaro, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 6963 | merged | skip.montanaro,2018-05-18 02:32 | |
| PR 6974 | merged | miss-islington,2018-05-18 18:39 | |
| PR 6975 | merged | miss-islington,2018-05-18 18:40 |
| Messages (6) | ||
|---|---|---|
| msg316931 - (view) | Author: Skip Montanaro (skip.montanaro) *  |
Date: 2018-05-17 13:53 |
| There is a leftover reference to "thread.get_ident" in the docstring for threading.ident. I believe it needs a leading underscore. Hopefully a PR isn't required for this. I'm not equipped to generate one at the moment, and this seems like a pretty trivial/obvious fix. | ||
| msg316934 - (view) | Author: Zachary Ware (zach.ware) *  |
Date: 2018-05-17 14:13 |
| Rather than a leading underscore, I think `thread.` should just be removed. `get_ident` is now exposed by the threading module itself. For a change this small, https://github.com/python/cpython/edit/master/Lib/threading.py can be used to create it, but every change requires a PR :) | ||
| msg317047 - (view) | Author: Zachary Ware (zach.ware) * |
Date: 2018-05-18 18:38 |
| New changeset 5634331a76dfe9fbe4b76475e11307a0922d6a15 by Zachary Ware (Skip Montanaro) in branch 'master': bpo-33556: Remove reference to thread module from docstring (GH-6963) https://github.com/python/cpython/commit/5634331a76dfe9fbe4b76475e11307a0922d6a15 | ||
| msg317051 - (view) | Author: miss-islington (miss-islington) | Date: 2018-05-18 19:32 |
| New changeset c6a5cc8f244ee71ce932003366411aacadda8dd0 by Miss Islington (bot) in branch '3.6': bpo-33556: Remove reference to thread module from docstring (GH-6963) https://github.com/python/cpython/commit/c6a5cc8f244ee71ce932003366411aacadda8dd0 | ||
| msg317054 - (view) | Author: Zachary Ware (zach.ware) * |
Date: 2018-05-18 19:46 |
| New changeset abde17e663edd6437cc7eb0405fe418449a25d72 by Zachary Ware (Miss Islington (bot)) in branch '3.7': bpo-33556: Remove reference to thread module from docstring (GH-6963) https://github.com/python/cpython/commit/abde17e663edd6437cc7eb0405fe418449a25d72 | ||
| msg317055 - (view) | Author: Zachary Ware (zach.ware) * |
Date: 2018-05-18 19:48 |
| Done, thanks Skip :) Can we convince you to reclaim your commit bits so you can click the buttons yourself next time? ;) |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:00 | admin | set | github: 77737 |
| 2018-05-18 19:48:49 | zach.ware | set | status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved |
| 2018-05-18 19:46:53 | zach.ware | set | messages: + |
| 2018-05-18 19:32:22 | miss-islington | set | nosy: + miss-islingtonmessages: + |
| 2018-05-18 18:40:47 | miss-islington | set | pull_requests: + <pull%5Frequest6630> |
| 2018-05-18 18:39:48 | miss-islington | set | pull_requests: + <pull%5Frequest6629> |
| 2018-05-18 18:38:42 | zach.ware | set | messages: + |
| 2018-05-18 02:32:03 | skip.montanaro | set | keywords: + patchstage: needs patch -> patch reviewpull_requests: + <pull%5Frequest6622> |
| 2018-05-17 14:13:20 | zach.ware | set | nosy: + zach.waremessages: + |
| 2018-05-17 13:53:10 | skip.montanaro | create |