Issue 33655: test_posix_fallocate fails on FreeBSD buildbots with ZFS file systems (original) (raw)

Seen on some of the various FreeBSD buildbots:

====================================================================== ERROR: test_posix_fallocate (test.test_posix.PosixTester)

Traceback (most recent call last): File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/test_posix.py", line 342, in test_posix_fallocate posix.posix_fallocate(fd, 0, 10) OSError: [Errno 22] Invalid argument

As discussed in Issue31106 and successors, the failure is due to posix_fallocate not being implemented on ZFS and the difficulty of determining in a platform-independent way what kind of file system a given file resides on. The test already ignores EINVAL ("Invalid argument") errors when run on Solaris-type platforms due to the common use of ZFS there. In lieu of a more precise test for fs type, we should also ignore EINVAL errors in this test when run on *BSD platforms. Also, rather than silently ignoring the error, it may be better to use a SkipTest message.