Issue 33670: Use errorlevel of Sphinx main() in Doc\make.bat (original) (raw)

Created on 2018-05-28 15:37 by adelfino, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7156 merged adelfino,2018-05-28 15:38
PR 7185 merged miss-islington,2018-05-28 23:29
PR 7186 merged miss-islington,2018-05-28 23:30
PR 7201 merged adelfino,2018-05-29 12:45
Messages (9)
msg317870 - (view) Author: Andrés Delfino (adelfino) * (Python triager) Date: 2018-05-28 15:37
Doc\make.bat is exiting without exposing Sphinx's main() return value, showing weird things like: C:\Users\adelfino\Desktop\Personal\repos\cpython\Doc>make venv Using py -3.6 (found with py.exe) Merging Misc/NEWS with py -3.6 -m blurb Running Sphinx v1.7.4 Sphinx error: Builder name venv not registered or available through entry point Build succeeded. All output should be in build\venv PR fixes this.
msg317874 - (view) Author: Andrés Delfino (adelfino) * (Python triager) Date: 2018-05-28 15:54
After the PR: C:\Users\adelfino\Desktop\Personal\repos\cpython\Doc>make venv Using py -3.6 (found with py.exe) Merging Misc/NEWS with py -3.6 -m blurb Running Sphinx v1.7.4 Sphinx error: Builder name venv not registered or available through entry point Build failed (exit code 2), check for error messages above. Any output will be found in build\venv
msg317959 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2018-05-28 23:28
New changeset 8c1ad0c4f69390fded09012e1ed5242c45753bb4 by Steve Dower (Andrés Delfino) in branch 'master': bpo-33670: Expose Sphinx errorlevel (GH-7156) https://github.com/python/cpython/commit/8c1ad0c4f69390fded09012e1ed5242c45753bb4
msg317975 - (view) Author: miss-islington (miss-islington) Date: 2018-05-29 01:45
New changeset 1827615500e94801653f67fd026a2c95930faf59 by Miss Islington (bot) in branch '3.7': bpo-33670: Expose Sphinx errorlevel (GH-7156) https://github.com/python/cpython/commit/1827615500e94801653f67fd026a2c95930faf59
msg317977 - (view) Author: miss-islington (miss-islington) Date: 2018-05-29 01:49
New changeset 08beaf7d60c247b485fb578be1ef14bbc796ca88 by Miss Islington (bot) in branch '3.6': bpo-33670: Expose Sphinx errorlevel (GH-7156) https://github.com/python/cpython/commit/08beaf7d60c247b485fb578be1ef14bbc796ca88
msg317978 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2018-05-29 01:54
Thanks for the contribution! Looks like the automatic backport to 2.7 won't work, so someone will have to do one manually. I'm happy to hit merge on a PR (whoever does it, make sure you follow the backport naming rules in the PR template).
msg317979 - (view) Author: Andrés Delfino (adelfino) * (Python triager) Date: 2018-05-29 01:57
Np! I'll take care of the backport :)
msg318128 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2018-05-29 22:30
New changeset 5583ef4777452e79278de80755d403f1c5b7781d by Steve Dower (Andrés Delfino) in branch '2.7': [2.7] bpo-33670: Expose Sphinx errorlevel (GH-7156). (GH-7201) https://github.com/python/cpython/commit/5583ef4777452e79278de80755d403f1c5b7781d
msg318129 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2018-05-29 22:31
Thanks!
History
Date User Action Args
2022-04-11 14:59:00 admin set github: 77851
2018-05-29 22:31:06 steve.dower set status: open -> closedmessages: + assignee: steve.dowerresolution: fixedstage: patch review -> resolved
2018-05-29 22:30:53 steve.dower set messages: +
2018-05-29 12:45:13 adelfino set stage: backport needed -> patch reviewpull_requests: + <pull%5Frequest6836>
2018-05-29 01:57:53 adelfino set messages: +
2018-05-29 01:54:30 steve.dower set assignee: steve.dower -> (no value)stage: patch review -> backport neededmessages: + versions: - Python 3.6, Python 3.7, Python 3.8
2018-05-29 01:49:53 miss-islington set messages: +
2018-05-29 01:45:37 miss-islington set nosy: + miss-islingtonmessages: +
2018-05-28 23:30:31 miss-islington set pull_requests: + <pull%5Frequest6821>
2018-05-28 23:29:33 miss-islington set pull_requests: + <pull%5Frequest6820>
2018-05-28 23:28:24 steve.dower set messages: +
2018-05-28 23:27:54 steve.dower set assignee: steve.dowercomponents: + Windowsnosy: + paul.moore, tim.golden, steve.dower, zach.ware
2018-05-28 15:54:01 adelfino set messages: +
2018-05-28 15:38:24 adelfino set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest6792>
2018-05-28 15:37:25 adelfino create