Issue 33711: Could not find externals/db-* in msi.py on license generation (original) (raw)

Issue33711

Created on 2018-05-31 11:13 by Ivan.Pozdeev, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7241 merged Ivan.Pozdeev,2018-05-31 11:13
Messages (5)
msg318284 - (view) Author: Ivan Pozdeev (Ivan.Pozdeev) * Date: 2018-05-31 11:13
c:\Users\Sasha\Documents\cpython\Tools\msi>python msi.py Traceback (most recent call last): File "msi.py", line 1372, in add_files(db) File "msi.py", line 956, in add_files generate_license() File "msi.py", line 928, in generate_license raise ValueError, "Could not find "+srcdir+"/externals/"+pat ValueError: Could not find c:\Users\Sasha\Documents\cpython/externals/db-* The dir in externals is actually called bsddb-. I've no idea how they can official releases
msg318285 - (view) Author: Ivan Pozdeev (Ivan.Pozdeev) * Date: 2018-05-31 11:15
... can be built with such a glaring mistake in the script.
msg320375 - (view) Author: Anselm Kruis (anselm.kruis) * Date: 2018-06-24 16:08
I'm build msi installers regularly and I can confirm the issue. PR 7241 is ok and should be merged.
msg320390 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2018-06-24 22:50
New changeset b18f09835720e14ac7d4cca1815fdcdcecd5d8d4 by Zachary Ware (native-api) in branch '2.7': bpo-33711: Fix license generation error in installer build script (GH-7241) https://github.com/python/cpython/commit/b18f09835720e14ac7d4cca1815fdcdcecd5d8d4
msg320391 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2018-06-24 22:51
Thanks for the patch, Ivan, and the review, Anselm!
History
Date User Action Args
2022-04-11 14:59:01 admin set github: 77892
2018-06-24 22:51:14 zach.ware set status: open -> closedresolution: fixedmessages: + stage: resolved
2018-06-24 22:50:26 zach.ware set messages: +
2018-06-24 16:08:01 anselm.kruis set nosy: + anselm.kruismessages: +
2018-05-31 16:24:16 ned.deily set nosy: + zach.ware, steve.dower
2018-05-31 11:15:17 Ivan.Pozdeev set messages: +
2018-05-31 11:13:44 Ivan.Pozdeev create