Issue 33906: IDLE: rename windows.py as window.py (original) (raw)
Issue33906
Created on 2018-06-19 22:52 by terry.reedy, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 7833 | merged | terry.reedy,2018-06-21 00:57 | |
| PR 7834 | merged | miss-islington,2018-06-21 01:27 | |
| PR 7835 | merged | miss-islington,2018-06-21 01:28 |
| Messages (6) | ||
|---|---|---|
| msg320003 - (view) | Author: Terry J. Reedy (terry.reedy) *  |
Date: 2018-06-19 22:52 |
| Change module 'windows' to 'window':: 1. 'calltips' and 'windows' are the only two plural module names. 2. The top menu entry was changed from 'Windows' to 'Window' some time ago. 3. 'windows' is also a OS. With all modules at least imported in a test, all imports in modules should be checked, so running test_idle after changing the file name should reveal all imports that need to be changed. What could have been the 'Window' class is called 'ListedTopLevel'. | ||
| msg320027 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2018-06-20 06:45 |
| Also rename idle_test.test_windows as test_window with git mv. Imports: F:\dev\3x\lib\idlelib\editor.py: 28: from idlelib import windows F:\dev\3x\lib\idlelib\idle_test\test_windows.py: 3: from idlelib import windows F:\dev\3x\lib\idlelib\macosx.py: 131: from idlelib import windows | ||
| msg320122 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2018-06-20 22:26 |
| Marking 2.7 for a search test. | ||
| msg320129 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2018-06-21 01:26 |
| New changeset a361e89d5ae3daefe9e8b8a7e889cd2ad8c45b77 by Terry Jan Reedy in branch 'master': bpo-33906: Rename idlelib.windows as window (#7833) https://github.com/python/cpython/commit/a361e89d5ae3daefe9e8b8a7e889cd2ad8c45b77 | ||
| msg320131 - (view) | Author: miss-islington (miss-islington) | Date: 2018-06-21 01:45 |
| New changeset f9243a22da6a609143e27abf3ca37a4f63d5aae9 by Miss Islington (bot) in branch '3.7': bpo-33906: Rename idlelib.windows as window (GH-7833) https://github.com/python/cpython/commit/f9243a22da6a609143e27abf3ca37a4f63d5aae9 | ||
| msg320132 - (view) | Author: miss-islington (miss-islington) | Date: 2018-06-21 01:52 |
| New changeset 2839da4e51da5d66fa3d6e57eba4ba04f0641dab by Miss Islington (bot) in branch '3.6': bpo-33906: Rename idlelib.windows as window (GH-7833) https://github.com/python/cpython/commit/2839da4e51da5d66fa3d6e57eba4ba04f0641dab |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:01 | admin | set | github: 78087 |
| 2018-06-21 02:05:06 | terry.reedy | set | status: open -> closedresolution: fixedstage: patch review -> resolved |
| 2018-06-21 01:52:23 | miss-islington | set | messages: + |
| 2018-06-21 01:45:38 | miss-islington | set | nosy: + miss-islingtonmessages: + |
| 2018-06-21 01:28:12 | miss-islington | set | pull_requests: + <pull%5Frequest7444> |
| 2018-06-21 01:27:15 | miss-islington | set | pull_requests: + <pull%5Frequest7443> |
| 2018-06-21 01:26:02 | terry.reedy | set | messages: + |
| 2018-06-21 00:57:08 | terry.reedy | set | pull_requests: + <pull%5Frequest7442> |
| 2018-06-20 22:28:21 | terry.reedy | set | versions: - Python 2.7 |
| 2018-06-20 22:26:36 | terry.reedy | set | messages: + versions: + Python 2.7 |
| 2018-06-20 07:12:54 | terry.reedy | set | pull_requests: - <pull%5Frequest7421> |
| 2018-06-20 06:48:51 | thatiparthy | set | keywords: + patchstage: needs patch -> patch reviewpull_requests: + <pull%5Frequest7421> |
| 2018-06-20 06:45:47 | terry.reedy | set | keywords: + easymessages: + |
| 2018-06-19 22:53:51 | terry.reedy | set | title: IDLE: change windows.py to window.py -> IDLE: rename windows.py as window.py |
| 2018-06-19 22:52:37 | terry.reedy | create |