Issue 33986: asyncio: Typo in documentation: BaseSubprocessTransport -> SubprocessTransport (original) (raw)
Issue33986
Created on 2018-06-27 22:46 by kbumsik, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 7981 | closed | kbumsik,2018-06-28 04:12 |
| Messages (5) | ||
|---|---|---|
| msg320638 - (view) | Author: Bumsik Kim (kbumsik) * | Date: 2018-06-27 22:46 |
| https://docs.python.org/3/library/asyncio-protocol.html#basesubprocesstransport I belive the doc has a wrong name "basesubprocesstransport" and it should be "Subprocesstransport". You can see this in the source code: https://github.com/python/cpython/blob/3.6/Lib/asyncio/transports.py | ||
| msg320823 - (view) | Author: Bumsik Kim (kbumsik) * | Date: 2018-07-01 05:16 |
| As a note, BaseSubprocessTransport is used for implementation of SubprocessTransport. BaseSubprocessTransport is not exposed outside of the module. | ||
| msg320858 - (view) | Author: Bumsik Kim (kbumsik) * | Date: 2018-07-02 09:33 |
| I also found that SubprocessTransport.close() does not reflect the changes done in #23347. | ||
| msg325031 - (view) | Author: Andrew Svetlov (asvetlov) *  |
Date: 2018-09-11 16:58 |
| Superseded by #33649 | ||
| msg325162 - (view) | Author: Bumsik Kim (kbumsik) * | Date: 2018-09-12 18:39 |
| #33649 does not solve a problem of SubprocessTransport.close() done in #23347. I made a PR #33649 directly to fix that. |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:02 | admin | set | github: 78167 |
| 2018-09-12 18:39:03 | kbumsik | set | messages: + |
| 2018-09-11 16:58:11 | asvetlov | set | status: open -> closedsuperseder: asyncio docs overhaulmessages: + resolution: duplicatestage: patch review -> resolved |
| 2018-07-02 09:33:06 | kbumsik | set | messages: + |
| 2018-07-01 05:16:48 | kbumsik | set | messages: + |
| 2018-06-28 04:12:11 | kbumsik | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest7592> |
| 2018-06-27 22:47:17 | vstinner | set | nosy: + asvetlov, yselivanovcomponents: + asyncio, - Documentationtitle: Typo: BaseSubprocessTransport -> SubprocessTransport -> asyncio: Typo in documentation: BaseSubprocessTransport -> SubprocessTransport |
| 2018-06-27 22:46:14 | kbumsik | create |