Issue 34003: csv.DictReader can return basic dict instead of OrderedDict (original) (raw)
Created on 2018-06-29 19:47 by selik, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 8014 | merged | selik,2018-06-29 19:59 | |
| PR 20657 | merged | eric.araujo,2020-06-05 19:08 | |
| PR 20770 | merged | miss-islington,2020-06-10 01:02 | |
| PR 20771 | merged | miss-islington,2020-06-10 01:02 |
| Messages (9) | ||
|---|---|---|
| msg320734 - (view) | Author: Michael Selik (selik) * | Date: 2018-06-29 19:47 |
| Since dicts are now keeping insertion order as of 3.7, we can switch to the more efficient construction of dict rather than OrderedDict for each row in the CSV file. | ||
| msg320735 - (view) | Author: Michael Selik (selik) * | Date: 2018-06-29 19:59 |
| Pull request. https://github.com/python/cpython/pull/8014 | ||
| msg320739 - (view) | Author: Eric V. Smith (eric.smith) *  |
Date: 2018-06-29 20:55 |
| The dict and OrderedDict APIs are slightly different, although I'm not sure anyone cares. See #32339. In that PR https://github.com/python/cpython/pull/4904, Guido said to not make this change. See also the python-dev discussion at https://mail.python.org/pipermail/python-dev/2017-December/151351.html If you feel strongly about this, I suggest discussing it on python-dev first. | ||
| msg320741 - (view) | Author: Michael Selik (selik) * | Date: 2018-06-29 21:13 |
| I searched for previously submitted issues, but somehow didn't spot #32339. I'll do some searching for whether anyone uses ``move_to_end`` on DictReader rows and respond to the mailing list with a report. | ||
| msg320748 - (view) | Author: Raymond Hettinger (rhettinger) * |
Date: 2018-06-30 00:50 |
| This might need a deprecation before switching but it would be useful. The DictReader can produced huge numbers of instances that would benefit from the smaller size. | ||
| msg334613 - (view) | Author: Raymond Hettinger (rhettinger) * |
Date: 2019-01-31 08:47 |
| New changeset 9f3f0931cfc58498086d287226650599a97412bb by Raymond Hettinger (Michael Selik) in branch 'master': bpo-34003: Use dict instead of OrderedDict in csv.DictReader (GH-8014) https://github.com/python/cpython/commit/9f3f0931cfc58498086d287226650599a97412bb | ||
| msg371148 - (view) | Author: miss-islington (miss-islington) | Date: 2020-06-10 01:02 |
| New changeset 7aed0524d4129766a6032326949ef7f91f6f6dfc by Éric Araujo in branch 'master': bpo-34003: Re-add versionchanged entry in csv docs (GH-20657) https://github.com/python/cpython/commit/7aed0524d4129766a6032326949ef7f91f6f6dfc | ||
| msg371151 - (view) | Author: miss-islington (miss-islington) | Date: 2020-06-10 01:26 |
| New changeset 663836e1179ea79eac12e55670af7e89a531a060 by Miss Islington (bot) in branch '3.8': [3.8] bpo-34003: Re-add versionchanged entry in csv docs (GH-20657) (GH-20771) https://github.com/python/cpython/commit/663836e1179ea79eac12e55670af7e89a531a060 | ||
| msg371152 - (view) | Author: miss-islington (miss-islington) | Date: 2020-06-10 01:26 |
| New changeset 73b728a779aa7d6d8f088c4b21447bba4bf3a351 by Miss Islington (bot) in branch '3.9': [3.9] bpo-34003: Re-add versionchanged entry in csv docs (GH-20657) (GH-20770) https://github.com/python/cpython/commit/73b728a779aa7d6d8f088c4b21447bba4bf3a351 |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:02 | admin | set | github: 78184 |
| 2020-06-10 01:26:39 | miss-islington | set | messages: + |
| 2020-06-10 01:26:19 | miss-islington | set | messages: + |
| 2020-06-10 01:02:52 | miss-islington | set | pull_requests: + <pull%5Frequest19969> |
| 2020-06-10 01:02:39 | miss-islington | set | pull_requests: + <pull%5Frequest19968> |
| 2020-06-10 01:02:15 | miss-islington | set | nosy: + miss-islingtonmessages: + |
| 2020-06-05 19:08:14 | eric.araujo | set | nosy: + eric.araujopull_requests: + <pull%5Frequest19876> |
| 2019-02-01 03:02:18 | rhettinger | set | resolution: not a bug -> fixed |
| 2019-02-01 03:02:05 | rhettinger | set | status: open -> closedresolution: not a bugstage: patch review -> resolved |
| 2019-01-31 08:47:55 | rhettinger | set | messages: + |
| 2018-06-30 00:50:21 | rhettinger | set | nosy: + rhettingermessages: + |
| 2018-06-29 21:13:07 | selik | set | messages: + |
| 2018-06-29 20:55:06 | eric.smith | set | nosy: + eric.smithmessages: + |
| 2018-06-29 20:02:17 | selik | set | type: performance |
| 2018-06-29 20:02:00 | selik | set | components: + Library (Lib) |
| 2018-06-29 19:59:52 | selik | set | messages: + |
| 2018-06-29 19:59:33 | selik | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest7622> |
| 2018-06-29 19:47:39 | selik | create |