Issue 34197: Make csv.Dialect attributes skipinitialspace, doublequote and strict booleans (original) (raw)
Issue34197
➜
This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/78378
classification
| Title: | Make csv.Dialect attributes skipinitialspace, doublequote and strict booleans | ||
|---|---|---|---|
| Type: | enhancement | Stage: | resolved |
| Components: | Library (Lib) | Versions: | Python 3.8 |
process
| Status: | closed | Resolution: | fixed |
|---|---|---|---|
| Dependencies: | Superseder: | ||
| Assigned To: | serhiy.storchaka | Nosy List: | serhiy.storchaka, xtreak |
| Priority: | normal | Keywords: | patch |
Created on 2018-07-23 11:06 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 8440 | merged | serhiy.storchaka,2018-07-24 15:46 |
| Messages (4) | ||
|---|---|---|
| msg322193 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2018-07-23 11:06 |
| Currently attributes skipinitialspace, doublequote and strict of the csv.Dialect class are integers 0 or 1. >>> import csv >>> d = csv.reader([]).dialect >>> d.skipinitialspace 0 >>> d.doublequote 1 >>> d.strict 0 The proposed PR makes them False or True. | ||
| msg322309 - (view) | Author: Karthikeyan Singaravelan (xtreak) * |
Date: 2018-07-24 15:36 |
| > The proposed PR makes them False or True. Sorry, is there a PR missing here? I hope you are referring to https://github.com/serhiy-storchaka/cpython/commit/f96e6969b7f73c3fd6ed2166ba3405f9e63b88f7 Thanks | ||
| msg322312 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-07-24 15:48 |
| Hmm, indeed, I forgot to create a PR. Thank you for catching this Karthikeyan! | ||
| msg322410 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-07-26 10:21 |
| New changeset 323748ad7446c76972c80dbbf510534dc5c22ae8 by Serhiy Storchaka in branch 'master': bpo-34197: Make _csv.Dialect attributes booleans. (GH-8440) https://github.com/python/cpython/commit/323748ad7446c76972c80dbbf510534dc5c22ae8 |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:03 | admin | set | github: 78378 |
| 2018-07-26 11:35:42 | serhiy.storchaka | set | status: open -> closedresolution: fixedstage: patch review -> resolved |
| 2018-07-26 10:21:13 | serhiy.storchaka | set | messages: + |
| 2018-07-24 15:48:21 | serhiy.storchaka | set | messages: + |
| 2018-07-24 15:46:54 | serhiy.storchaka | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest7966> |
| 2018-07-24 15:36:33 | xtreak | set | nosy: + xtreakmessages: + |
| 2018-07-23 11:06:28 | serhiy.storchaka | create |
Supported by The Python Software Foundation,
Powered by Roundup
Copyright © 1990-2022, Python Software Foundation
Legal Statements