Issue 34225: distutils._msvccompiler should trim INCLUDE/LIB directories (original) (raw)
Issue34225
➜
This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/78406
classification
| Title: | distutils._msvccompiler should trim INCLUDE/LIB directories | ||
|---|---|---|---|
| Type: | Stage: | resolved | |
| Components: | Distutils, Windows | Versions: | Python 3.8, Python 3.7, Python 3.6 |
process
| Status: | closed | Resolution: | fixed |
|---|---|---|---|
| Dependencies: | Superseder: | ||
| Assigned To: | steve.dower | Nosy List: | dstufft, eric.araujo, paul.moore, steve.dower, tim.golden, zach.ware |
| Priority: | normal | Keywords: | patch |
Created on 2018-07-25 14:54 by steve.dower, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 8464 | merged | steve.dower,2018-07-25 15:24 | |
| PR 8478 | merged | steve.dower,2018-07-26 11:26 | |
| PR 8477 | merged | miss-islington,2018-07-29 09:02 |
| Messages (3) | ||
|---|---|---|
| msg322361 - (view) | Author: Steve Dower (steve.dower) *  |
Date: 2018-07-25 14:54 |
| _msvccompiler reads the INCLUDE and LIB environment variables when building and adds each directory to the command line. However, if any of these end with os.sep (specifically, '\'), then it will escape the quoting and break the entire command. We should rstrip(os.sep) on each item from this list. | ||
| msg322414 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2018-07-26 11:23 |
| New changeset 5473f061f518aef5367a535999a407305fb12aff by Steve Dower in branch 'master': bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash. (GH-8464) https://github.com/python/cpython/commit/5473f061f518aef5367a535999a407305fb12aff | ||
| msg322616 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2018-07-29 09:02 |
| New changeset 8f6a7e100d68fddc9fb98f5cbdf1981994360407 by Steve Dower (Miss Islington (bot)) in branch '3.6': bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash. (GH-8464) https://github.com/python/cpython/commit/8f6a7e100d68fddc9fb98f5cbdf1981994360407 |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:03 | admin | set | github: 78406 |
| 2018-07-29 09:02:19 | steve.dower | set | messages: + |
| 2018-07-29 09:02:18 | miss-islington | set | pull_requests: + <pull%5Frequest8057> |
| 2018-07-26 16:19:24 | steve.dower | set | status: open -> closedresolution: fixedstage: patch review -> resolved |
| 2018-07-26 11:26:56 | steve.dower | set | pull_requests: + <pull%5Frequest8001> |
| 2018-07-26 11:23:16 | steve.dower | set | messages: + |
| 2018-07-25 15:24:21 | steve.dower | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest7987> |
| 2018-07-25 14:54:28 | steve.dower | create |
Supported by The Python Software Foundation,
Powered by Roundup
Copyright © 1990-2022, Python Software Foundation
Legal Statements