Issue 34657: pyconfig.h macro "timezone" name clashes with user source are likely (original) (raw)

Issue34657

Created on 2018-09-13 06:10 by bwanamarko, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Messages (2)
msg325235 - (view)	Author: Mark Mikofski (bwanamarko)	Date: 2018-09-13 06:10
TL;DR: if PC user compiles source which defines "timezone" in a header, and includes Python.h after the header, then the macro also called "timezone" in pyconfig.h will redefine the users source, yielding unexpected results. see Cython google group for an actual use case where this occurred: https://groups.google.com/forum/#!topic/cython-users/pjbhYrpl_rU trying to compile NREL SPA code which has a header file with a struct with a timezone field fails with the following traceback: spa.h(88): error C2032: '__timezone': function cannot be member of struct '' here's the macro in PC/pyconfig.h in master as of 5489bdad https://github.com/python/cpython/blob/5489bdad5143050b8bb89b648b3c00d951b72d4f/PC/pyconfig.h#L202 /* VS 2015 defines these names with a leading underscore */ #if _MSC_VER >= 1900 #define timezone _timezone #define daylight _daylight #define tzname _tzname #endif
msg325249 - (view)	Author: Zachary Ware (zach.ware) *	Date: 2018-09-13 14:40
This is a duplicate of bpo-24643.