Issue 34673: make the eval loop more editable (original) (raw)
Issue34673
Created on 2018-09-14 04:14 by benjamin.peterson, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 9289 | merged | benjamin.peterson,2018-09-14 04:15 |
| Messages (2) | ||
|---|---|---|
| msg325320 - (view) | Author: Benjamin Peterson (benjamin.peterson) *  |
Date: 2018-09-14 04:14 |
| The TARGET macro in ceval.c hides control flow, most importantly the case statement. This confuses my editor and makes it indent things automatically improperly. This can be fixed by moving the case statements out of the TARGET macro. | ||
| msg325512 - (view) | Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2018-09-17 05:38 |
| New changeset ddd1949fea59f256e51191540a4446f75ed608fa by Benjamin Peterson in branch 'master': closes bpo-34673: Tweaks to make ceval more editable. (GH-9289) https://github.com/python/cpython/commit/ddd1949fea59f256e51191540a4446f75ed608fa |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:05 | admin | set | github: 78854 |
| 2018-09-17 05:38:13 | benjamin.peterson | set | status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved |
| 2018-09-14 04:15:54 | benjamin.peterson | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest8720> |
| 2018-09-14 04:14:32 | benjamin.peterson | create |