Issue 34740: Get rid of tp_getattro in ossaudiodev.oss_audio_device (original) (raw)
Issue34740
Created on 2018-09-19 14:31 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 9421 | merged | serhiy.storchaka,2018-09-19 14:33 |
| Messages (2) | ||
|---|---|---|
| msg325768 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2018-09-19 14:31 |
| Currently ossaudiodev.oss_audio_device has the tp_getattro slot for handling some attributes. The proposed PR replaces it with tp_members and tp_getset. Benefits: constant time access, names of these attributes are added to the result of dir() and help(), better structured code. | ||
| msg327041 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-10-04 07:42 |
| New changeset 5f5a7781c8bf7bcc476d3e05d980711be3920724 by Serhiy Storchaka in branch 'master': bpo-34740: Get rid of tp_getattro in ossaudiodev.oss_audio_device. (GH-9421) https://github.com/python/cpython/commit/5f5a7781c8bf7bcc476d3e05d980711be3920724 |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:06 | admin | set | github: 78921 |
| 2018-10-04 07:43:24 | serhiy.storchaka | set | status: open -> closedresolution: fixedstage: patch review -> resolved |
| 2018-10-04 07:42:10 | serhiy.storchaka | set | messages: + |
| 2018-09-19 14:33:56 | serhiy.storchaka | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest8841> |
| 2018-09-19 14:31:29 | serhiy.storchaka | create |