Issue 34836: test_ssl.test_default_ecdh_curve needs no tls1.3 flag in 2.7, for now (original) (raw)

Issue34836

Created on 2018-09-28 16:32 by xnox, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9626 merged xnox,2018-09-28 16:34
Messages (3)
msg326644 - (view) Author: Dimitri John Ledkov (xnox) * Date: 2018-09-28 16:32
test_default_ecdh_curve fails, as ssl.OP_NO_TLSv1_3 is not set on the context. and the test case can only work with non-tls1.3 connections. this indicates that the pull request that sprinkled ssl.OP_NO_TLSv1_3 everywhere was not backported, taking into account all the other backports that did subsequently remove those flags in many test cases. at the moment that test case is failing, but it would be nice if it didn't.
msg345071 - (view) Author: Alyssa Coghlan (ncoghlan) * (Python committer) Date: 2019-06-09 05:45
New changeset 99b5c940d3471e0ed6579771d94e7342d7c733e0 by Nick Coghlan (Dimitri John Ledkov) in branch '2.7': [2.7] bpo-34836: fix test_default_ecdh_curve, needs no tlsv1.3. (GH-9626) https://github.com/python/cpython/commit/99b5c940d3471e0ed6579771d94e7342d7c733e0
msg367372 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2020-04-27 03:37
This seems to have been fixed, so I'm closing it as such. With 2.7 at EOL, this would be closed anyway, but "fixed" sounds nicer :)
History
Date User Action Args
2022-04-11 14:59:06 admin set github: 79017
2020-04-27 03:37:00 zach.ware set status: open -> closednosy: + zach.waremessages: + resolution: fixedstage: patch review -> resolved
2019-06-09 05:45:09 ncoghlan set nosy: + ncoghlanmessages: +
2018-12-26 22:13:34 gregory.p.smith set assignee: christian.heimes
2018-10-01 19:42:06 cstratak set nosy: + cstratak
2018-09-28 17:39:30 xtreak set nosy: + christian.heimes
2018-09-28 16:34:40 xnox set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest9024>
2018-09-28 16:32:44 xnox create