Issue 35565: Add detail to an assertion failure message in wsgiref (original) (raw)
Issue35565
➜
This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/79746
classification
| Title: | Add detail to an assertion failure message in wsgiref | ||
|---|---|---|---|
| Type: | enhancement | Stage: | resolved |
| Components: | Library (Lib) | Versions: | Python 3.8, Python 3.7 |
process
| Status: | closed | Resolution: | fixed |
|---|---|---|---|
| Dependencies: | Superseder: | ||
| Assigned To: | cheryl.sabella | Nosy List: | cheryl.sabella, rhettinger |
| Priority: | normal | Keywords: | easy, patch |
Created on 2018-12-23 01:19 by rhettinger, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 11293 | merged | cheryl.sabella,2018-12-23 02:34 | |
| PR 11317 | merged | rhettinger,2018-12-25 23:19 | |
| PR 11317 | merged | rhettinger,2018-12-25 23:19 | |
| PR 11317 | merged | rhettinger,2018-12-25 23:19 |
| Messages (3) | ||
|---|---|---|
| msg332378 - (view) | Author: Raymond Hettinger (rhettinger) *  |
Date: 2018-12-23 01:19 |
| On line 236 in Lib/wsgiref/handlers.py, we get the assertion message, "Hop-by-hop headers not allowed". That message should should show the *name* and *value* that triggered the failure. Otherwise, it is difficult to know which header caused the problem (in my case, it was Connection: close). | ||
| msg332522 - (view) | Author: Raymond Hettinger (rhettinger) * |
Date: 2018-12-25 23:19 |
| New changeset 5ef4fc241aea6759ef3f55b1ef564aebc492a0db by Raymond Hettinger (Cheryl Sabella) in branch 'master': bpo-35565: Add detail to assertion failure message in wsgiref (GH-11293) https://github.com/python/cpython/commit/5ef4fc241aea6759ef3f55b1ef564aebc492a0db | ||
| msg332523 - (view) | Author: Raymond Hettinger (rhettinger) * |
Date: 2018-12-25 23:59 |
| New changeset b6af23ebf9d6667fa222e804f045735289b4527f by Raymond Hettinger in branch 'master': Revert "bpo-35565: Add detail to assertion failure message in wsgiref" (GH-11317) https://github.com/python/cpython/commit/b6af23ebf9d6667fa222e804f045735289b4527f |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:09 | admin | set | github: 79746 |
| 2018-12-26 00:01:16 | rhettinger | set | status: open -> closedresolution: fixedstage: patch review -> resolved |
| 2018-12-25 23:59:09 | rhettinger | set | messages: + |
| 2018-12-25 23:19:59 | rhettinger | set | pull_requests: + <pull%5Frequest10567> |
| 2018-12-25 23:19:55 | rhettinger | set | pull_requests: + <pull%5Frequest10566> |
| 2018-12-25 23:19:52 | rhettinger | set | pull_requests: + <pull%5Frequest10565> |
| 2018-12-25 23:19:15 | rhettinger | set | messages: + |
| 2018-12-23 02:34:31 | cheryl.sabella | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest10523> |
| 2018-12-23 01:19:21 | rhettinger | create |
Supported by The Python Software Foundation,
Powered by Roundup
Copyright © 1990-2022, Python Software Foundation
Legal Statements