Issue 35852: Fixed tests regenerating using CRLF when running it on Windows (original) (raw)

Issue35852

Created on 2019-01-29 16:27 by addons_zz, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 11697 closed python-dev,2019-01-29 16:27
PR 11697 closed python-dev,2019-01-29 16:27
Messages (2)
msg334529 - (view) Author: Addons Zz (addons_zz) Date: 2019-01-29 16:27
When generating the file on Windows by running ``` python test/test_profile.py -r ``` The file has its line ending converted from LF to CRLF, creating noise on the git diff.
msg335766 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-02-17 10:05
PR 11697 keeps existing CRLFs in unmodified part, by writes bare LFs for auto-generated part. The result can contain mixed newlines. The current code looks correct to me. Just git should be configured to convert LF to platform specific newlines in source files.
History
Date User Action Args
2022-04-11 14:59:10 admin set github: 80033
2019-02-17 14:23:43 addons_zz set status: open -> closedstage: patch review -> resolved
2019-02-17 10:05:55 serhiy.storchaka set keywords:patch, patchnosy: + serhiy.storchakamessages: +
2019-01-29 16:27:39 python-dev set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest11545>
2019-01-29 16:27:36 python-dev set keywords: + patchstage: (no value)pull_requests: + <pull%5Frequest11544>
2019-01-29 16:27:01 addons_zz create