Issue35976
Created on 2019-02-12 04:02 by Paul Monson, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests |
|
|
|
| URL |
Status |
Linked |
Edit |
| PR 11825 |
merged |
Paul Monson,2019-02-12 04:06 |
|
| Messages (3) |
|
|
| msg335325 - (view) |
Author: Steve Dower (steve.dower) *  |
Date: 2019-02-12 16:36 |
| Just updating the title to reflect what the patch actually does in isolation - you probably should update the PR and NEWS items to match. It's fine (probably preferred) to mention in the issue and PR text that it's been split out from another PR. But we have to account for the (very small) chance that this part is merged and the rest is not - in that case, having a standalone description of the change is much more helpful. |
|
|
| msg335538 - (view) |
Author: Steve Dower (steve.dower) * |
Date: 2019-02-14 16:31 |
| New changeset 8a1657b93469580ef345c7c91738587f3d76e87d by Steve Dower (Paul Monson) in branch 'master': bpo-35976: Enable Windows projects to build with platform ARM32 (GH-11825) https://github.com/python/cpython/commit/8a1657b93469580ef345c7c91738587f3d76e87d |
|
|
| msg335545 - (view) |
Author: Steve Dower (steve.dower) * |
Date: 2019-02-14 16:52 |
| Thanks, Paul! Hopefully when you rebase the main change on top of this it will be easier to see the actual impact. |
|
|
| History |
|
|
|
| Date |
User |
Action |
Args |
| 2022-04-11 14:59:11 |
admin |
set |
github: 80157 |
| 2019-02-14 16:52:09 |
steve.dower |
set |
status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved |
| 2019-02-14 16:31:34 |
steve.dower |
set |
messages: + |
| 2019-02-12 16:36:57 |
steve.dower |
set |
messages: + title: PCBuild file changes for arm32 should be separated from code changes for review -> Enable Windows projects to build with platform ARM32 |
| 2019-02-12 04:06:36 |
Paul Monson |
set |
keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest11855> |
| 2019-02-12 04:02:51 |
Paul Monson |
create |
|