Issue 36105: Windows: use GetNativeSystemInfo instead of GetSystemInfo (original) (raw)

Issue36105

Created on 2019-02-25 10:57 by giampaolo.rodola, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Messages (4)
msg336512 - (view)	Author: Giampaolo Rodola' (giampaolo.rodola) *	Date: 2019-02-25 10:57
This is what MS doc says about GetSystemInfo: https://docs.microsoft.com/en-us/windows/desktop/api/sysinfoapi/nf-sysinfoapi-getsysteminfo <<To retrieve accurate information for an application running on WOW64, call the GetNativeSystemInfo function.>> $ grep -r GetSystemInfo Modules/_ctypes/malloc_closure.c: GetSystemInfo(&systeminfo); Modules/mmapmodule.c: GetSystemInfo(&si); Modules/mmapmodule.c: GetSystemInfo(&si); Modules/posixmodule.c: GetSystemInfo(&sysinfo);
msg336513 - (view)	Author: Ronald Oussoren (ronaldoussoren) *	Date: 2019-02-25 11:55
I guess it depends on what the information is used for. From a quick glance at the code I'd say that the current usage is correct, and that GetNativeSystemInfo could be used when reporting about the currently running system (for example by functions in the platform module).
msg336527 - (view)	Author: Steve Dower (steve.dower) *	Date: 2019-02-25 14:58
Yeah, possibly only the CPU count one could change, but there's an ongoing discussion on another bug about whether that should return the actual count or the usable count. 32-bit processes have restrictions beyond what the system is capable of, and I believe we want those reflected in each of these cases.
msg336532 - (view)	Author: Giampaolo Rodola' (giampaolo.rodola) *	Date: 2019-02-25 15:28
It appears you guys are right. Sorry for the noise.