Issue 36140: An incorrect check in _msi.c's msidb_getsummaryinformation() (original) (raw)

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/80321

classification

Title: An incorrect check in _msi.c's msidb_getsummaryinformation()
Type: behavior Stage: resolved
Components: Windows Versions: Python 3.8, Python 3.7, Python 2.7

process

Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ZackerySpytz, miss-islington, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2019-02-27 18:38 by ZackerySpytz, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 12074 merged ZackerySpytz,2019-02-27 18:40
PR 12221 merged miss-islington,2019-03-07 18:20
PR 12222 merged miss-islington,2019-03-07 18:20
Messages (5)
msg336776 - (view) Author: Zackery Spytz (ZackerySpytz) * (Python triager) Date: 2019-02-27 18:38
msidb_getsummaryinformation() checks the wrong variable after calling PyObject_NEW().
msg337419 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-03-07 18:20
New changeset bf94cc7b496a379e1f604aa2e4080bb70ca4020e by Steve Dower (Zackery Spytz) in branch 'master': bpo-36140: Fix an incorrect check in msidb_getsummaryinformation() (GH-12074) https://github.com/python/cpython/commit/bf94cc7b496a379e1f604aa2e4080bb70ca4020e
msg337420 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2019-03-07 18:21
Thanks for the patch! Once the backports merge, I (or someone else) will close the issue.
msg337423 - (view) Author: miss-islington (miss-islington) Date: 2019-03-07 18:39
New changeset 6ba95c38c556ad4d254c5af34f439a1307ed585c by Miss Islington (bot) in branch '3.7': bpo-36140: Fix an incorrect check in msidb_getsummaryinformation() (GH-12074) https://github.com/python/cpython/commit/6ba95c38c556ad4d254c5af34f439a1307ed585c
msg337425 - (view) Author: miss-islington (miss-islington) Date: 2019-03-07 18:49
New changeset b19943ec97b80db97dd93ed714615f757cc12ad3 by Miss Islington (bot) in branch '2.7': bpo-36140: Fix an incorrect check in msidb_getsummaryinformation() (GH-12074) https://github.com/python/cpython/commit/b19943ec97b80db97dd93ed714615f757cc12ad3
History
Date User Action Args
2022-04-11 14:59:11 admin set github: 80321
2019-03-07 19:31:09 steve.dower set status: open -> closedresolution: fixedstage: patch review -> resolved
2019-03-07 18:49:18 miss-islington set messages: +
2019-03-07 18:39:46 miss-islington set nosy: + miss-islingtonmessages: +
2019-03-07 18:21:38 steve.dower set messages: +
2019-03-07 18:20:34 steve.dower set messages: +
2019-03-07 18:20:32 miss-islington set pull_requests: + <pull%5Frequest12212>
2019-03-07 18:20:25 miss-islington set pull_requests: + <pull%5Frequest12211>
2019-02-27 18:40:25 ZackerySpytz set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest12093>
2019-02-27 18:38:06 ZackerySpytz create