| msg336841 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2019-02-28 15:37 |
| The detect_modules() method of setup.py became longer and longer over the years. It is now 1128 lines long. It's way too long: it becomes very hard to track the lifetime of a variable and many variables are overriden on purpose or not. Shorter functions help to track the lifetime of variables, ease review and reduce the number of bugs. |
|
|
| msg336851 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2019-02-28 16:48 |
| New changeset 4cbea518a0827d23a41a45b03a8af729c2f16605 by Victor Stinner in branch 'master': bpo-36146: Refactor setup.py (GH-12093) https://github.com/python/cpython/commit/4cbea518a0827d23a41a45b03a8af729c2f16605 |
|
|
| msg336919 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2019-03-01 14:31 |
| New changeset 8058bdae3e5e1f77a202d9dc907b4189409c9b03 by Victor Stinner in branch 'master': bpo-36146: Refactor setup.py: PyBuildExt.add() method (GH-12097) https://github.com/python/cpython/commit/8058bdae3e5e1f77a202d9dc907b4189409c9b03 |
|
|
| msg336923 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2019-03-01 14:59 |
| New changeset 625dbf2567533e6001d57e5969fba75c1b6ece43 by Victor Stinner in branch 'master': bpo-36146: Refactor setup.py: Add PyBuildExt.srcdir (GH-12124) https://github.com/python/cpython/commit/625dbf2567533e6001d57e5969fba75c1b6ece43 |
|
|
| msg336926 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2019-03-01 15:43 |
| New changeset 5ec33a1c25a586552751ca35c85ab7ecb6b06ec3 by Victor Stinner in branch 'master': bpo-36146: Split setup.py into subfunctions (GH-12125) https://github.com/python/cpython/commit/5ec33a1c25a586552751ca35c85ab7ecb6b06ec3 |
|
|
| msg336927 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2019-03-01 16:19 |
| New changeset c991f2415d4eef663039a83125aa6aad81672680 by Victor Stinner in branch 'master': bpo-36146: Don't run code at setup.py top level (GH-12127) https://github.com/python/cpython/commit/c991f2415d4eef663039a83125aa6aad81672680 |
|
|
| msg336935 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2019-03-01 17:21 |
| New changeset cfe172dc6bd0a02d36db31ffabcc38f9320a4510 by Victor Stinner in branch 'master': bpo-36146: Add TEST_EXTENSIONS to setup.py (GH-12129) https://github.com/python/cpython/commit/cfe172dc6bd0a02d36db31ffabcc38f9320a4510 |
|
|
| msg336938 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2019-03-01 17:23 |
| Ok, I splitted my giant PR 12068 into multiple small commits. So they are easier to review and understand ;-) I close the issue. |
|
|
| msg337019 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2019-03-02 19:37 |
| New changeset 96d81583be98cec9728636186ea32b662cb091d5 by Victor Stinner in branch 'master': bpo-36146: Fix inc_dirs in setup.py on macOS (GH-12098) https://github.com/python/cpython/commit/96d81583be98cec9728636186ea32b662cb091d5 |
|
|
| msg339761 - (view) |
Author: miss-islington (miss-islington) |
Date: 2019-04-09 15:20 |
| New changeset 2ee077f7955e0349074f16a7afee40b4914619f7 by Miss Islington (bot) (xdegaye) in branch 'master': bpo-36544 : Fix regression introduced in bpo-36146 (GH-12708) https://github.com/python/cpython/commit/2ee077f7955e0349074f16a7afee40b4914619f7 |
|
|
| msg339774 - (view) |
Author: miss-islington (miss-islington) |
Date: 2019-04-09 16:40 |
| New changeset 8abc3f4f91e6b523c761c7a6fa2e3405019803a1 by Miss Islington (bot) (Christian Heimes) in branch 'master': bpo-36577: setup.py reports missing OpenSSL again (GH-12746) https://github.com/python/cpython/commit/8abc3f4f91e6b523c761c7a6fa2e3405019803a1 |
|
|
| msg339776 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2019-04-09 16:41 |
| For the record, I introduced a regression which has been fixed in bpo-36544. |
|
|