Issue 36168: DOC: Fix capitalization in string.rst (original) (raw)
Created on 2019-03-02 12:21 by cheryl.sabella, last changed 2022-04-11 14:59 by admin. This issue is now closed.
Pull Requests | |||
---|---|---|---|
URL | Status | Linked | Edit |
PR 14485 | merged | python-dev,2019-06-30 12:52 | |
PR 14519 | merged | miss-islington,2019-07-01 16:12 |
Messages (8) | ||
---|---|---|
msg337008 - (view) | Author: Cheryl Sabella (cheryl.sabella) * ![]() |
Date: 2019-03-02 12:21 |
In `string.rst`, under get_value(), `Subsequent` shouldn't be capitalized after the semi-colon. For compound field names, these functions are only called for the first component of the field name; ---> Subsequent <--- components are handled through normal attribute and indexing operations. Assigning to @Mariatta for the sprints. | ||
msg346896 - (view) | Author: Lysandros Nikolaou (lys.nikolaou) * ![]() |
Date: 2019-06-29 20:08 |
Mariatta noted at https://mail.python.org/archives/list/core-mentorship@python.org/message/KFIGNAGJKWQXCXG72VGIGGA3OCKUHOFC/ that these issues are not reserved and are now available for first-time contributors. | ||
msg346898 - (view) | Author: Readul Hasan Chayan (heemayl) | Date: 2019-06-29 20:26 |
If no one has any problem I would like to work on this. This will be my first contribution if it happens. | ||
msg346929 - (view) | Author: Krishna Oza (Krishna Oza) * | Date: 2019-06-30 12:57 |
I am getting the error "GitHub PR already added to issue" when submitting my Github PR for this issue. | ||
msg346959 - (view) | Author: miss-islington (miss-islington) | Date: 2019-07-01 06:04 |
New changeset 12b436e3b079fb3e3a7197c089df90a77e3bdd77 by Miss Islington (bot) (Krishna Oza) in branch 'master': bpo-36168: Lowercase the word "subsequent" in get_value doc (GH-14485) https://github.com/python/cpython/commit/12b436e3b079fb3e3a7197c089df90a77e3bdd77 | ||
msg346979 - (view) | Author: Sanyam Khurana (CuriousLearner) * ![]() |
Date: 2019-07-01 08:54 |
Mariatta, I see it also needs a backport to 3.8 We can close it once the backport is completed. | ||
msg347042 - (view) | Author: miss-islington (miss-islington) | Date: 2019-07-01 16:30 |
New changeset 59ec9ee4d7f3c2444efb989e96f5124e1c246de5 by Miss Islington (bot) in branch '3.8': bpo-36168: Lowercase the word "subsequent" in get_value doc (GH-14485) https://github.com/python/cpython/commit/59ec9ee4d7f3c2444efb989e96f5124e1c246de5 | ||
msg347045 - (view) | Author: Sanyam Khurana (CuriousLearner) * ![]() |
Date: 2019-07-01 16:39 |
Backport successfully completed. Marking this as fixed. Congrats on your first patch, Krishna! Thank you, everyone! |
History | |||
---|---|---|---|
Date | User | Action | Args |
2022-04-11 14:59:11 | admin | set | github: 80349 |
2019-07-01 16:39:26 | CuriousLearner | set | status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved |
2019-07-01 16:30:51 | miss-islington | set | messages: + |
2019-07-01 16:12:41 | miss-islington | set | pull_requests: + <pull%5Frequest14334> |
2019-07-01 08:54:51 | CuriousLearner | set | nosy: + CuriousLearnermessages: + |
2019-07-01 06:04:25 | miss-islington | set | nosy: + miss-islingtonmessages: + |
2019-06-30 12:57:04 | Krishna Oza | set | nosy: + Krishna Ozamessages: + |
2019-06-30 12:52:19 | python-dev | set | keywords: + patchstage: needs patch -> patch reviewpull_requests: + <pull%5Frequest14302> |
2019-06-29 20:26:42 | heemayl | set | nosy: + heemaylmessages: + |
2019-06-29 20:08:36 | lys.nikolaou | set | nosy: + lys.nikolaoumessages: + |
2019-06-26 12:17:06 | cheryl.sabella | set | keywords: + easyversions: + Python 3.9, - Python 3.7 |
2019-03-02 12:21:02 | cheryl.sabella | create |