Issue 36186: [2.7] Coverity scan: Modules/linuxaudiodev.c , fd handle is not closed. (original) (raw)
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/80367
classification
Title: | [2.7] Coverity scan: Modules/linuxaudiodev.c , fd handle is not closed. | ||
---|---|---|---|
Type: | Stage: | resolved | |
Components: | Extension Modules | Versions: | Python 2.7 |
process
Status: | closed | Resolution: | fixed |
---|---|---|---|
Dependencies: | Superseder: | ||
Assigned To: | Nosy List: | cstratak, vstinner | |
Priority: | normal | Keywords: | patch |
Created on 2019-03-04 15:37 by cstratak, last changed 2022-04-11 14:59 by admin. This issue is now closed.
Pull Requests | |||
---|---|---|---|
URL | Status | Linked | Edit |
PR 12163 | merged | cstratak,2019-03-04 15:40 |
Messages (3) | ||
---|---|---|
msg337131 - (view) | Author: Charalampos Stratakis (cstratak) * | Date: 2019-03-04 15:37 |
There are two places [0][1] in the code where NULL is returned but the fd handle is not closed. [0] https://github.com/python/cpython/blob/2.7/Modules/linuxaudiodev.c#L129 [1] https://github.com/python/cpython/blob/2.7/Modules/linuxaudiodev.c#L133 | ||
msg337302 - (view) | Author: STINNER Victor (vstinner) * ![]() |
Date: 2019-03-06 14:12 |
New changeset b2aefd77e1da438aed649d018d6aa504ec35eac8 by Victor Stinner (stratakis) in branch '2.7': [2.7] bpo-36186: Fix linuxaudiodev.linux_audio_device() error handling (GH-12163) https://github.com/python/cpython/commit/b2aefd77e1da438aed649d018d6aa504ec35eac8 | ||
msg337304 - (view) | Author: STINNER Victor (vstinner) * ![]() |
Date: 2019-03-06 14:34 |
Thanks Charalampos Stratakis! |
History | |||
---|---|---|---|
Date | User | Action | Args |
2022-04-11 14:59:12 | admin | set | github: 80367 |
2019-03-06 14:34:00 | vstinner | set | status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved |
2019-03-06 14:12:10 | vstinner | set | nosy: + vstinnermessages: + |
2019-03-04 15:40:50 | cstratak | set | keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest12161> |
2019-03-04 15:37:06 | cstratak | create |