Issue 36195: initializer is not a valid param in ThreadPoolExecutor (original) (raw)

Created on 2019-03-05 14:28 by harman786, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 12182 merged harman786,2019-03-05 17:09
Messages (8)
msg337189 - (view) Author: Harmandeep Singh (harman786) * Date: 2019-03-05 14:28
In Python 3.6, the docs for ThreadPoolExecutor mentions the following line: initializer is an optional callable that is called at the start of each worker thread; initargs is a tuple of arguments passed to the initializer. Should initializer raise an exception, all currently pending jobs will raise a BrokenThreadPool, as well any attempt to submit more jobs to the pool. But, from my experiment in Python 3.6 and 3.7, I have observed that `initializer` and `initargs` were introduced in Python 3.7.
msg337198 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python committer) Date: 2019-03-05 15:05
Thanks for the report. You are correct. The parameters were introduced in in 3.7. It seems that this backported by mistake with PR 10958 where minor grammar was fixed with 40a61da40d252626f8b9ff524d76c1f0ccb3a4f7 but backporting caused the whole paragraph to be added to 3.6. 3.6 is in security fixes only mode. So I am not sure about the fix being merged. I am adding Ned to take a call on this.
msg337201 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2019-03-05 15:19
If someone is willing to make a doc fix PR for this, I will merge it for 3.6.
msg337202 - (view) Author: Harmandeep Singh (harman786) * Date: 2019-03-05 15:23
I will raise a PR
msg337203 - (view) Author: Stéphane Wirtel (matrixise) * (Python committer) Date: 2019-03-05 15:25
ok, I was working on a PR for this issue. but I am going to classify it as easy.
msg337205 - (view) Author: Stéphane Wirtel (matrixise) * (Python committer) Date: 2019-03-05 15:27
harman786 good luck for your PR, if you need a review. Have a nice day,
msg338153 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2019-03-18 01:53
New changeset e601ef0fa384d149f6759fff3c18762a8c63851e by Ned Deily (Harmandeep Singh) in branch '3.6': bpo-36195: Remove the ThreadPoolExecutor documentation mentioning the initializer feature added in Python 3.7 (GH-12182) https://github.com/python/cpython/commit/e601ef0fa384d149f6759fff3c18762a8c63851e
msg338154 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2019-03-18 01:54
Thanks for the PR!
History
Date User Action Args
2022-04-11 14:59:12 admin set github: 80376
2019-03-18 01:54:00 ned.deily set status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved
2019-03-18 01:53:11 ned.deily set messages: +
2019-03-05 17:09:56 harman786 set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest12178>
2019-03-05 15:27:27 matrixise set messages: +
2019-03-05 15:26:01 matrixise set keywords: + easy
2019-03-05 15:25:53 matrixise set nosy: + matrixisemessages: +
2019-03-05 15:23:42 harman786 set messages: +
2019-03-05 15:19:43 ned.deily set messages: +
2019-03-05 15:05:08 xtreak set nosy: + xtreak, ned.deilymessages: +
2019-03-05 14:32:56 harman786 set assignee: docs@pythoncomponents: + Documentationnosy: + docs@python
2019-03-05 14:28:02 harman786 create