Issue 36412: A possible crash in dictobject.c's new_dict() (original) (raw)

Issue36412

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification

Title:	A possible crash in dictobject.c's new_dict()
Type:	crash	Stage:	resolved
Components:	Interpreter Core	Versions:	Python 3.8

process

Status:	closed	Resolution:	fixed
Dependencies:		Superseder:
Assigned To:		Nosy List:	ZackerySpytz, methane
Priority:	normal	Keywords:	patch

Created on 2019-03-24 01:49 by ZackerySpytz, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL	Status	Linked	Edit
PR 12519	merged	ZackerySpytz,2019-03-24 01:52

Messages (3)
msg338711 - (view)	Author: Zackery Spytz (ZackerySpytz) *	Date: 2019-03-24 01:49
PyDict_New() calls new_dict() with the "empty_values" array. If the PyObject_GC_New() call in new_dict() fails, new_dict() will call PyMem_FREE() on this array, causing a crash.
msg338712 - (view)	Author: Inada Naoki (methane) *	Date: 2019-03-24 02:23
New changeset 3d07c1ee1d2d475b74816117981d6ec752c26c23 by Inada Naoki (Zackery Spytz) in branch 'master': bpo-36412: fix a possible crash in dictobject.c's new_dict() (GH-12519) https://github.com/python/cpython/commit/3d07c1ee1d2d475b74816117981d6ec752c26c23
msg338713 - (view)	Author: Inada Naoki (methane) *	Date: 2019-03-24 02:52
Thank you, nice catch! How did you find it?

History
Date	User	Action	Args
2022-04-11 14:59:12	admin	set	github: 80593
2019-03-24 02:52:58	methane	set	messages: +
2019-03-24 02:23:44	methane	set	status: open -> closedresolution: fixedstage: patch review -> resolved
2019-03-24 02:23:36	methane	set	nosy: + methanemessages: +
2019-03-24 01:52:29	ZackerySpytz	set	keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest12470>
2019-03-24 01:49:34	ZackerySpytz	create