Issue 36571: Lib/smtplib.py have some pep8 issues (original) (raw)

Created on 2019-04-09 08:29 by Marcin Niemira, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 12741 closed n0npax,2019-04-09 08:33
Messages (4)
msg339714 - (view) Author: Marcin Niemira (Marcin Niemira) Date: 2019-04-09 08:29
pycodestyle (pep8) reports some issues on linting for Lib/smtplib.py I believe we can fix most of them and apply some improvements due to pep-572. PR on GH. Are contributions like this valuable?
msg339716 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python committer) Date: 2019-04-09 08:51
Generally changes only related to PEP 8 are not merged since they pollute git history while using blame and a lot of other modules also don't adhere to PEP 8. New code written can have PEP 8 enforced or the related parts of the code can be refactored while making a change but style alone changes/refactors are not merged. Also the current PR uses PEP 572 assignment expressions. It's okay to use it in new code but doesn't add value in converting old code to use it. I have added email module maintainers to take a call on the same.
msg339717 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2019-04-09 09:16
Yes, I totally agree with xtreak. We try to avoid unnecessary code changes. Any change comes with a risk and cost to pay. PEP 8 is just a guideline for new code.
msg339719 - (view) Author: Marcin Niemira (Marcin Niemira) Date: 2019-04-09 09:32
Thanks for the explanation. I'll close issue and PR. Cheers :)
History
Date User Action Args
2022-04-11 14:59:13 admin set github: 80752
2019-04-09 09:32:09 Marcin Niemira set status: open -> closedmessages: + stage: patch review -> resolved
2019-04-09 09:16:36 christian.heimes set nosy: + christian.heimesmessages: +
2019-04-09 08:51:09 xtreak set nosy: + barry, r.david.murray, xtreakmessages: + components: + email
2019-04-09 08:33:57 n0npax set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest12664>
2019-04-09 08:29:14 Marcin Niemira create