| msg341385 - (view) |
Author: Mikhail Gerasimov (germn) |
Date: 2019-05-04 14:20 |
| Compare: https://docs.python.org/3.6/library/asyncio-sync.html#asyncio.Lock https://docs.python.org/3.8/library/asyncio-sync.html#asyncio.Lock First version is much more detailed. It allows to avoid confusions like one with unlocking order: https://stackoverflow.com/q/55951233/1113207 |
|
|
| msg341394 - (view) |
Author: Hrvoje Nikšić (hniksic) * |
Date: 2019-05-04 17:39 |
| Also, the docstring of asyncio.Lock still states: When more than one coroutine is blocked in acquire() waiting for the state to turn to unlocked, only one coroutine proceeds when a release() call resets the state to unlocked; first coroutine which is blocked in acquire() is being processed. |
|
|
| msg341720 - (view) |
Author: Stéphane Wirtel (matrixise) *  |
Date: 2019-05-07 13:13 |
| Hi hniksic, Could you add your Github Account to your BPO account, without that, we can't work on your PR, and you need to sign the CLA. Thank you |
|
|
| msg341735 - (view) |
Author: Hrvoje Nikšić (hniksic) * |
Date: 2019-05-07 14:35 |
| How do I connect the accounts? Please note that I've previously submitted PRs which have been accepted, e.g. https://bugs.python.org/issue34476 and https://bugs.python.org/issue35465 |
|
|
| msg341741 - (view) |
Author: Hrvoje Nikšić (hniksic) * |
Date: 2019-05-07 14:54 |
| Ok, found it, and I've now updated the github name on my bpo account. I'll gladly sign the CLA if needed, I thought it wasn't necessary for small changes based on previous experience. Please advise whether it's necessary here. |
|
|
| msg341744 - (view) |
Author: Stéphane Wirtel (matrixise) * |
Date: 2019-05-07 15:06 |
| If I read the Licensing section into the devguide, a contributor (me, your, etc..) has to sign the CLA. https://devguide.python.org/pullrequest/#cla "To accept your change we must have your formal approval for distributing your work under the PSF license." the verb is must -> required! Thank you |
|
|
| msg341758 - (view) |
Author: Andrew Svetlov (asvetlov) * |
Date: 2019-05-07 15:48 |
| I would say that unblock order is an implementation detail (which is unlikely be changed though). I'm biased how should we document it. Yuri, your opinion is very welcome. |
|
|
| msg342195 - (view) |
Author: Hrvoje Nikšić (hniksic) * |
Date: 2019-05-11 14:59 |
| @matrixise I've signed the CLA in the meantime, and it's now confirmed by https://check-python-cla.herokuapp.com/ Thanks for the pointer. |
|
|
| msg342207 - (view) |
Author: Stéphane Wirtel (matrixise) * |
Date: 2019-05-11 16:37 |
| Hi Hrvoje Nikšić, Thank you for the CLA, now, we need the opinion from Yury and their approval, I am not an expert of the asyncio. Thank you, |
|
|
| msg343901 - (view) |
Author: miss-islington (miss-islington) |
Date: 2019-05-29 17:08 |
| New changeset 34f4f5efea730504216ee19f237734e0bb0104ee by Miss Islington (bot) (Hrvoje Nikšić) in branch 'master': bpo-36794: Document that Lock.acquire is fair. (GH-13082) https://github.com/python/cpython/commit/34f4f5efea730504216ee19f237734e0bb0104ee |
|
|
| msg343907 - (view) |
Author: miss-islington (miss-islington) |
Date: 2019-05-29 18:24 |
| New changeset 4e1e887203ef069bf293ecabd945f7567d6a4879 by Miss Islington (bot) in branch '3.7': bpo-36794: Document that Lock.acquire is fair. (GH-13082) https://github.com/python/cpython/commit/4e1e887203ef069bf293ecabd945f7567d6a4879 |
|
|