Issue 36802: Revert back StreamWriter awrite/aclose but provide await writer.write() and await writer.close() (original) (raw)

Created on 2019-05-05 14:10 by asvetlov, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Messages (3)
msg341450 - (view)	Author: Andrew Svetlov (asvetlov) *	Date: 2019-05-05 14:10
Yuri and I decided that `writer.awrite()` and `writer.aclose()` look ugly. Instead, we return awaitable object from these methods to allow both `writer.write(b'data')` and `await writer.write(b'data')` for the method. The same for `writer.close()` call.
msg341994 - (view)	Author: Andrew Svetlov (asvetlov) *	Date: 2019-05-09 19:15
New changeset a076e4f5e42b85664693191d04cfb33e2f9acfa5 by Andrew Svetlov in branch 'master': bpo-36802: Drop awrite()/aclose(), support await write() and await close() instead (#13099) https://github.com/python/cpython/commit/a076e4f5e42b85664693191d04cfb33e2f9acfa5
msg342471 - (view)	Author: STINNER Victor (vstinner) *	Date: 2019-05-14 15:22
It seems like the commit a076e4f5e42b85664693191d04cfb33e2f9acfa5 introduced a regression: bpo-36870, test_drain_raises() of test_asyncio started to fail randomly, mostly on Windows. bpo-36870 is making AppVeyor failing on pull requests and make Windows buildbots fail randomly. I wrote PR 13316 to revert the commit to get more time to find a proper fix. https://pythondev.readthedocs.io/ci.html#revert-on-fail