| msg349542 - (view) |
Author: Netzeband (netbnd) |
Date: 2019-08-13 10:42 |
| When decorating a function and using a forward declaration as type hint, the typing.get_type_hints function does not work anymore, since it cannot find the forward declared name in the namespace. After debugging I think, the typing.get_type_hints function is actually using the namespace of the decorator instead of the decorated function. When using a normal class type (no forward declaration) everything works fine and also when not using any decorator it works like expected. As a workaround, one could pass the local namespace to typing.get_type_hints. However in normal usecases this function is used for runtime typechecking in a deep call hierarchy. So one would normally not have access to the right local namespace, only to the function object itself. However there is another easy workaround. At least when using the functool.wraps method to create a function decorator. The decorated functions has a "__wrapped__" attribute, which references the original function. When using "typing.get_type_hints(function.__wrapped__)" instead of "typing.get_type_hints(function)", it works like expected. So maybe this could be built in into the get_type_hints method. |
|
|
| msg349565 - (view) |
Author: Guido van Rossum (gvanrossum) *  |
Date: 2019-08-13 14:38 |
| Using `__wrapped__` if present sounds like a good idea. Ivan, what do you think? Netzeband, have you considered submitting a PR with the necessary changes (and tests and docs)? |
|
|
| msg349580 - (view) |
Author: Ivan Levkivskyi (levkivskyi) * |
Date: 2019-08-13 16:22 |
| > Using `__wrapped__` if present sounds like a good idea. Yeah, I like this idea, this will likely cover most use cases (since most people actually do use @wraps). |
|
|
| msg349581 - (view) |
Author: Guido van Rossum (gvanrossum) * |
Date: 2019-08-13 16:28 |
| Maybe we should tag this issue "newcomer friendly"? It seems a pretty open and shut case. |
|
|
| msg349594 - (view) |
Author: Netzeband (netbnd) |
Date: 2019-08-13 17:57 |
| Thanks for your feedback. I can create a pull-request. However, I did it never before for the Python-Lib, so I first have to setup the correct environment for that and ensure, that I can run all test-cases. Since I'm on vacation soon, it could take several weeks. If someone wants to solve the issue earlier, please don't hesitate. I will write it in this issue ticket, as soon as I finished the PR. |
|
|
| msg355477 - (view) |
Author: Benjamin Edwards (benedwards14) * |
Date: 2019-10-27 16:13 |
| Hey Netzeband, are you still working on this, or would it be ok for me to have a go? If all you needed was help with a PR let me know, i have some experience? |
|
|
| msg355501 - (view) |
Author: Joannah Nanjekye (nanjekyejoannah) * |
Date: 2019-10-27 20:03 |
| @benedwards14 Feel free to open a PR. @netbnd said anyone can take on the issue since he may take long to revert with a PR. |
|
|
| msg355502 - (view) |
Author: Joannah Nanjekye (nanjekyejoannah) * |
Date: 2019-10-27 20:05 |
| Actually there is a patch. So please @netbnd please open a PR https://github.com/python/cpython |
|
|
| msg355585 - (view) |
Author: Netzeband (netbnd) |
Date: 2019-10-28 18:34 |
| Hello, I'm very sorry, I was not able to find the time to finish the patch in the quality I wanted to have. So @benedwards14 please feel free to provide a pull request. Best regards, André |
|
|
| msg355643 - (view) |
Author: Benjamin Edwards (benedwards14) * |
Date: 2019-10-29 10:39 |
| Thanks Netzeband, Will get on this. Ben |
|
|
| msg355747 - (view) |
Author: Netzeband (netbnd) |
Date: 2019-10-31 12:28 |
| Thanks a lot! |
|
|
| msg356390 - (view) |
Author: Ivan Levkivskyi (levkivskyi) * |
Date: 2019-11-11 21:34 |
| The PR was linked by mistake (it is for a different issue), so I unlinked it. |
|
|
| msg356470 - (view) |
Author: Benjamin Edwards (benedwards14) * |
Date: 2019-11-12 15:20 |
| Have opened a PR, let me know if there is anything that needs fixing |
|
|
| msg357184 - (view) |
Author: Ivan Levkivskyi (levkivskyi) * |
Date: 2019-11-21 17:25 |
| New changeset 0aca3a3a1e68b4ca2d334ab5255dfc267719096e by Ivan Levkivskyi (benedwards14) in branch 'master': bpo-37838: get_type_hints for wrapped functions with forward reference (GH-17126) https://github.com/python/cpython/commit/0aca3a3a1e68b4ca2d334ab5255dfc267719096e |
|
|
| msg357187 - (view) |
Author: miss-islington (miss-islington) |
Date: 2019-11-21 17:43 |
| New changeset 30e5bd8471d7531d051796c01e8ede01ade883dc by Miss Islington (bot) in branch '3.7': bpo-37838: get_type_hints for wrapped functions with forward reference (GH-17126) https://github.com/python/cpython/commit/30e5bd8471d7531d051796c01e8ede01ade883dc |
|
|
| msg357188 - (view) |
Author: miss-islington (miss-islington) |
Date: 2019-11-21 17:43 |
| New changeset 9458c5c42bbe5fb6ef2393c9ee66f012a2c13ca3 by Miss Islington (bot) in branch '3.8': bpo-37838: get_type_hints for wrapped functions with forward reference (GH-17126) https://github.com/python/cpython/commit/9458c5c42bbe5fb6ef2393c9ee66f012a2c13ca3 |
|
|