| msg355656 - (view) |
Author: (serge-sans-paille) * |
Date: 2019-10-29 15:17 |
| See https://bugs.llvm.org/show_bug.cgi?id=43830, but basically the follwing code: ``` // a.c #include <Python.h> int main() { Py_Initialize(); PyRun_SimpleString("import readline; print(readline.__doc__)"); return 0; } ``` compiled like this: ``` % gcc a.c `./install/bin/python3-config --cflags --ldflags --libs` -lpython3.9 ``` runs fine: ``` % ./a.out Importing this module enables command line editing using GNU readline. ``` However the following: ``` % gcc a.c `./install/bin/python3-config --cflags --ldflags --libs` -ledit -lpython3.9 ``` compiles but segfaults at runtime. |
|
|
| msg355672 - (view) |
Author: Ned Deily (ned.deily) *  |
Date: 2019-10-29 19:42 |
| This appears to be essentially a duplicate of Issue13631 which has long proposed full support of libedit. |
|
|
| msg355931 - (view) |
Author: (serge-sans-paille) * |
Date: 2019-11-04 08:27 |
| @ned I(d rather see this as an evolution of Issue13631, as this solves a problem when libreadline and libedit are both loaded in the same executable. As such, using libedit instead of readline wouldn't solve the issue: what if the program Python is embeded in is linked to readline? I find python approach relatively elegant: detect the linked library at runtime and use the ad-hoc implementation based on this. An other option would be to dlopen readline using the RTLD_LOCAL flag, so that we get a better, non intrusive symbol resolution. What do you think? |
|
|
| msg357808 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2019-12-04 16:03 |
| New changeset 7105319ada2e663659020cbe9fdf7ff38f421ab2 by Victor Stinner (serge-sans-paille) in branch 'master': bpo-38634: Allow non-apple build to cope with libedit (GH-16986) https://github.com/python/cpython/commit/7105319ada2e663659020cbe9fdf7ff38f421ab2 |
|
|
| msg357810 - (view) |
Author: miss-islington (miss-islington) |
Date: 2019-12-04 16:21 |
| New changeset 68669ef7883ea6338ca441e50f4f9d975f54d017 by Miss Islington (bot) in branch '3.8': bpo-38634: Allow non-apple build to cope with libedit (GH-16986) https://github.com/python/cpython/commit/68669ef7883ea6338ca441e50f4f9d975f54d017 |
|
|
| msg357813 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2019-12-04 17:08 |
| Thanks serge-sans-paille for the bug report and the fix! I backported it to 3.8 since it could be automated, but I don't think that it's worth it to backport it to 3.7: https://github.com/python/cpython/pull/16986#issuecomment-561711232 |
|
|
| msg378261 - (view) |
Author: Colin Watson (cjwatson) * |
Date: 2020-10-08 17:33 |
| FWIW I just ran into what I believe to be this bug with the Launchpad test suite on Python 3.6.9. The output shows some normal test output followed by: No entry for terminal type "unknown"; using dumb terminal settings. bind: Invalid command `enable-meta-key'. No entry for terminal type "unknown"; using dumb terminal settings. No entry for terminal type "unknown"; using dumb terminal settings. Segmentation fault The test suite imports a lot of stuff, but it includes something which links against libLLVM which links against libedit (I haven't worked out exactly what, but probably GTK-related). Then something else much later imports readline - again, I haven't worked out what yet, as it's taken me a day just to set up the exact right environment in which to reproduce this at all and an strace doesn't make the cause of the import especially clear. So I understand why you see this as a rare use case, but it's *extremely* confusing and a massive time sink when you do run across it, as the cause is a long way distant from the effect and it can arise in situations where it is in no way deliberate to have this sort of setup, but rather an emergent effect of several other things. |
|
|
| msg378285 - (view) |
Author: Colin Watson (cjwatson) * |
Date: 2020-10-08 19:45 |
| Here's a reasonably minimal reproduction recipe reduced from real code in the Launchpad test suite that doesn't require compiling a separate C extension. It fails on Ubuntu 18.04 with the gir1.2-gtk-3.0, python3-gi, and xvfb packages installed. (The xvfb-run part is just so that it works on a headless system; you can omit it if you have a working $DISPLAY.) xvfb-run python3 -c 'from gi.repository import Gtk; import readline' |
|
|
| msg386676 - (view) |
Author: Gregory P. Smith (gregory.p.smith) * |
Date: 2021-02-09 01:06 |
| New changeset e1f77695132e814728cda982f11342a2e3c7272c by Roland Hieber in branch 'master': bpo-13501: allow choosing between readline and libedit (GH-24189) https://github.com/python/cpython/commit/e1f77695132e814728cda982f11342a2e3c7272c |
|
|