Issue 42235: [macOS] Use --enable-optimizations in build-installer.py (original) (raw)

Created on 2020-11-01 16:31 by ronaldoussoren, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 23079 merged ronaldoussoren,2020-11-01 17:03
Messages (6)
msg380152 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2020-11-01 16:31
With recent enough compilers it is possible to use --enable-optimzations when building the installer.
msg380154 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-11-01 16:37
See also bpo-41181 "[macOS] Build macOS installer with LTO and PGO optimizations".
msg380155 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2020-11-01 16:45
I'm working on a PR. The current version of build-installer.py doesn't use LTO/PGO because installers are build on macOS 10.9 where the compiler doesn't reliably support this. Recent compilers should work a lot better. The upcoming PR enables --enable-optimizations when building on macOS 10.15 or later (Xcode 11 or 12), mostly because that's what I'm testing with. I'm listing 41100 as a dependency because having that is the only way to make use of this PR at the moment: build-installer.py uses --enable-universalsdk and 41100 introduces "universal2" as a set of architectures that can be build using Xcode 12. All other sets of architectures require Xcode 10 or older.
msg392761 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2021-05-03 03:43
New changeset e08059edef3be07ada3058d68ad2c9cc13b7418e by Ronald Oussoren in branch 'master': bpo-42235: [macOS] Use LTO/PGO in build-installer.py with new enough compilers (GH-23079) https://github.com/python/cpython/commit/e08059edef3be07ada3058d68ad2c9cc13b7418e
msg392762 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2021-05-03 03:49
Thanks for the PR. I am only going to apply this to the 3.10 branch for now. Perhaps when we have more experience with it, it could be backported to 3.9.x. First appearance in 3.10.0b1.
msg393432 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2021-05-10 21:01
Thanks Ronald!
History
Date User Action Args
2022-04-11 14:59:37 admin set github: 86401
2021-08-02 03:26:38 ned.deily set pull_requests: - <pull%5Frequest24521>
2021-05-10 21:01:46 vstinner set messages: +
2021-05-03 04:01:11 miss-islington set pull_requests: + <pull%5Frequest24521>
2021-05-03 03:49:30 ned.deily set status: open -> closedversions: + Python 3.10messages: + resolution: fixedstage: patch review -> resolved
2021-05-03 03:46:05 ned.deily set pull_requests: - <pull%5Frequest24519>
2021-05-03 03:45:58 ned.deily set pull_requests: - <pull%5Frequest24518>
2021-05-03 03:44:06 miss-islington set pull_requests: + <pull%5Frequest24519>
2021-05-03 03:44:01 miss-islington set nosy: + miss-islingtonpull_requests: + <pull%5Frequest24518>
2021-05-03 03:43:59 ned.deily set messages: +
2020-11-01 17:03:28 ronaldoussoren set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest21998>
2020-11-01 16:45:14 ronaldoussoren set nosy: + ned.deilymessages: + dependencies: + Support macOS 11 and Apple Silicon Macscomponents: + macOS
2020-11-01 16:37:51 vstinner set nosy: + vstinnermessages: +
2020-11-01 16:31:13 ronaldoussoren create