Issue 47233: show_caches option affects code positions reported by dis.get_instructions(...) (original) (raw)

Issue47233

Created on 2022-04-05 19:47 by 15r10nk, last changed 2022-04-11 14:59 by admin.

Files
File name Uploaded Description Edit
test2.py 15r10nk,2022-04-05 19:47
Pull Requests
URL Status Linked Edit
PR 32406 open 15r10nk,2022-04-07 20:40
Messages (3)
msg416810 - (view) Author: 15r10nk (15r10nk) * Date: 2022-04-05 19:47
The Instructions reported by dis.get_instructions(...) and dis.Bytecode(...) have different positions depending on the value of their show_caches argument. test2.py reproduces the problem.
msg416828 - (view) Author: Brandt Bucher (brandtbucher) * (Python committer) Date: 2022-04-05 23:01
Nice catch. The fix should be pretty simple: just move this line... https://github.com/python/cpython/blob/c1d93b6411f975d67e43942f1a2745a22983c18c/Lib/dis.py#L425 ...up to the top of the for loop. Are you interested in working on this?
msg416944 - (view) Author: 15r10nk (15r10nk) * Date: 2022-04-07 20:52
I moved the line. Is there anything else required? unittests?
History
Date User Action Args
2022-04-11 14:59:58 admin set github: 91389
2022-04-07 20:52:49 15r10nk set messages: +
2022-04-07 20:40:01 15r10nk set keywords: + patchstage: patch reviewpull_requests: + <pull%5Frequest30430>
2022-04-05 23:01:52 brandtbucher set messages: +
2022-04-05 22:53:45 brandtbucher set nosy: + brandtbucher
2022-04-05 19:47:24 15r10nk create