Issue 9924: sqlite3 SELECT does not BEGIN a transaction, but should according to spec (original) (raw)
Created on 2010-09-23 03:56 by zzzeek, last changed 2022-04-11 14:57 by admin.
Messages (7)
Author: mike bayer (zzzeek) *
Date: 2010-09-23 03:56
Copying this bug from the pysqlite tracker, at http://code.google.com/p/pysqlite/issues/detail?id=21 , as the issue has been opened for two days with no reply. (side node - should sqlite3 bugs be reported here or on the pysqlite tracker ?) The text below was originally written by Randall Nortman:
Pysqlite does not open a transaction in the database until a DML statement is encountered (INSERT, UPDATE, or DELETE). A DQL (SELECT) statement will not cause a transaction to be opened if one is not already opened. This is the documented behavior, but it is not what is intended by the spec (PEP 249). The spec intends a transaction to always be open (per the spec author), and this is what happens in other DB-API drivers. For more information, see the this DB-SIG mailing list post (by the PEP 249 author):
http://mail.python.org/pipermail/db-sig/2010-September/005645.html
For additional background, see this thread on the SQLAlchemy mailing list, which is the source of the attached test case:
What steps will reproduce the problem?
- See attached test case. Run it as is, and the final conn1.commit() statement will complete successfully.
- Uncomment the c2.execute("BEGIN") line and run again; this time conn1.commit() hangs until a timeout, then a "Database is locked" error is returned.
What is the expected output? What do you see instead?
The BEGIN should be issued implicitly, and even without doing it explicitly, the commit should block and then return the DB locked error.
What version of the product are you using? On what operating system?
Python 2.6.6 with its built-in sqlite3 module, on Debian Squeeze x86.
import sqlite3 import os
if os.path.exists("file.db"): os.unlink("file.db")
conn1 = sqlite3.connect("file.db")
c1 = conn1.cursor()
c1.execute("PRAGMA read_uncommitted=SERIALIZABLE")
c1.execute("""create table foo (id integer primary key, data varchar(30))""") c1.execute("insert into foo(id, data) values (1, 'data1')") c1.close() conn1.commit()
c1 = conn1.cursor() c1.execute("select * from foo where id=1") row1 = c1.fetchone() c1.close()
conn2 = sqlite3.connect("file.db") c2 = conn2.cursor()
c2.execute("PRAGMA read_uncommitted=SERIALIZABLE")
sqlite3 should be doing this automatically.
when called, conn1's commit blocks
#c2.execute("BEGIN") c2.execute("select * from foo where id=1") row2 = c2.fetchone() c2.close()
c1 = conn1.cursor() c1.execute("update foo set data='data2'")
print "About to commit conn1..." conn1.commit()
Author: mike bayer (zzzeek) *
Date: 2010-09-23 04:02
My own comment here is that I'm supposing the "late BEGIN" behavior is to cut down on SQLite's file locking. I think a way to maintain that convenience for most cases, while allowing the stricter behavior that makes SERIALIZABLE isolation worthwhile, would be an option to sqlite3.connect() that moves the implicit BEGIN to before any DQL, not just DML, statement.
Author: Gerhard Häring (ghaering) * 
Date: 2010-09-23 10:44
Yes Mike. Avoiding unnecessary locks was exactly the reason for this behaviour. I agree that for serializable transactions I'd need to make some changes.
Author: Daniel Holth (dholth) *
Date: 2011-02-22 21:10
What should this option be called?
connect(strict=True) ?
Author: mike bayer (zzzeek) *
Date: 2014-01-09 21:13
see also http://bugs.python.org/issue10740, which also relates to pysqlite attempting to make guesses as to when transactions should begin and end.
Author: Rian Hunter (rhunter)
Date: 2016-03-23 16:38
This bug can also lead to subtle and unintuitive "database is locked" bugs, even when a large timeout is set on the connection. Many, many people are affected by this bug (search the web for "python sqlite database is locked"). I've attached code that demonstrates this issue.
I disagree that the current behavior cuts down on SQLite file locking. As soon as any SELECT statement is opened, an implicit lock is held by SQLite (whether it resides within a BEGIN block or not): https://www.sqlite.org/lockingv3.html
SQLite has been designed to do its own "late locking." Pysqlite does not need to duplicate this behavior.
This is a clear-as-day bug and should be fixed.
Author: Antoine Pitrou (pitrou) *
Date: 2017-12-05 21:02
See https://bugs.python.org/issue32215 for what seems to be a related bug.
Also note that pysqlite now seems to be using a different logic: https://github.com/ghaering/pysqlite/blob/master/src/cursor.c#L537-L548 Also this changeset: https://github.com/ghaering/pysqlite/commit/94eae5002967a51782f36ce9b7b81bba5b4379db
As a sidenote, this seems to mean that the stdlib sqlite module doesn't receive updates anymore from its author...?
History
Date
User
Action
Args
2022-04-11 14:57:06
admin
set
github: 54133
2021-05-19 11:16:15
erlendaasland
set
nosy: + erlendaasland
2017-12-05 21:06:56
pitrou
set
assignee: ghaering ->
versions: + Python 3.7, - Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5
2017-12-05 21:06:41
pitrou
set
nosy: + berker.peksag
2017-12-05 21:02:38
pitrou
set
nosy: + pitrou, r.david.murray
messages: +
2017-12-02 08:22:53
Allen Li
set
nosy: + Allen Li
2017-01-20 09:11:22
palaviv
set
nosy: + palaviv
2016-03-23 17:29:08
berker.peksag
link
2016-03-23 16:39:00
rhunter
set
versions: + Python 3.2, Python 3.5, Python 3.6
2016-03-23 16:38:51
rhunter
set
files: + unintuitive_sqlite_behavior.py
nosy: + rhunter
messages: +
2015-01-11 02:03:56
ghaering
set
assignee: ghaering
2014-01-09 23🔞02
pitrou
set
versions: + Python 3.3, Python 3.4, - Python 3.1, Python 3.2
2014-01-09 21:13:42
zzzeek
set
messages: +
2011-02-22 21:10:54
dholth
set
nosy: + dholth
messages: +
2010-09-23 13:19:17
rnortman
set
nosy: + rnortman
2010-09-23 10:44:47
ghaering
set
messages: +
2010-09-23 08:10:35
ned.deily
set
nosy: + ghaering
versions: - Python 2.6, Python 2.5, Python 3.3
2010-09-23 04:02:36
zzzeek
set
messages: +
2010-09-23 03:56:05
zzzeek
create