disable TLS compression with OpenSSL. - Code Review (original) (raw)

Issue 10825183: net: disable TLS compression with OpenSSL. (Closed)

Created: 8 years, 4 months ago by agl Modified: 8 years, 3 months ago Reviewers: joth, wtc, klobag.chromium CC: chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, joth Base URL: svn://svn.chromium.org/chrome/trunk/src Visibility: Public. More Reviews	Description net: disable TLS compression with OpenSSL. BUG=139744Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149947 Patch Set 1# Created: 8 years, 4 months ago Download[raw] [tar.bz2] Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -4 lines 0 comments Download Messages Total messages: 8 (0 generated) Expand Messages | Collapse Messages agl 8 years, 4 months ago (2012-08-03 18:27:52 UTC)#1 joth Lgtm I can't see the linked bug , but guess this is necessary :-) 8 years, 4 months ago (2012-08-03 18:39:32 UTC)#2 Lgtm I can't see the linked bug , but guess this is necessary :-) commit-bot: I haz the power CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/10825183/1 8 years, 4 months ago (2012-08-03 19:43:17 UTC)#3 CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/10825183/1 klobag.chromium lgtm 8 years, 4 months ago (2012-08-03 21:00:36 UTC)#4 lgtm wtc LGTM. 8 years, 4 months ago (2012-08-03 21:16:24 UTC)#5 LGTM. commit-bot: I haz the power Change committed as 149947 8 years, 4 months ago (2012-08-03 22:35:15 UTC)#6 Change committed as 149947 indutny Now, almost every aware person on internet has pulled your change in one's project, it's ... 8 years, 3 months ago (2012-09-12 19:11:44 UTC)#7 Now, almost every aware person on internet has pulled your change in one's project, it's time to revert this commit just to troll everyone! joost The reason is this?: http://arstechnica.com/security/2012/09/crime-hijacks-https-sessions/ 8 years, 3 months ago (2012-09-13 09:35:31 UTC)#8 The reason is this?: http://arstechnica.com/security/2012/09/crime-hijacks-https-sessions/ Expand Messages	Collapse Messages

Issue 10825183: net: disable TLS compression with OpenSSL. (Closed)
Created 8 years, 4 months ago by agl
Modified 8 years, 3 months ago
Reviewers: klobag.chromium, joth, wtc
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 0