flags and Finch gate it. - Code Review (original) (raw)
Description
Add minimum TLS version control to about:flags and Finch gate it. This change adds an entry to about:flags to control the minimum TLS version as requested by Darin. This will allow Android and ChromeOS users to reenable SSLv3 in Chrome 40 if they need to. Additionally, this gates the SSLv3 disabling with Finch. At the moment the experiment doesn't actually exist and so will always return the empty string. However, should we need to, we can define it and put everyone in the Enabled group. BUG=427671, 419870Committed: https://crrev.com/0a4a16346d0a921949ad8f423934350a3b504e70Cr-Commit-Position: refs/heads/master@{#302754}
Patch Set 1#
Patch Set 2 : ...#
Total comments: 2
Patch Set 3 : Address rch's comments.#
Patch Set 4 : Fix --ssl-version-min support.#
Patch Set 5 : Add missing comma in ChromeOS code.#
Patch Set 6 : ...#
Messages
Total messages: 22 (9 generated)
| agl | agl@chromium.org changed reviewers: + asvitkine@chromium.org, rsleevi@chromium.org | 6 years, 1 month ago (2014-10-31 20:56:04 UTC)#1 |
|---|
| agl | | 6 years, 1 month ago (2014-10-31 20:56:05 UTC)#2 | | ------- | | --------------------------------------------------------- |
| Alexei Svitkine (slow) | | 6 years, 1 month ago (2014-10-31 21:02:14 UTC)#3 | | -------------------------- | | --------------------------------------------------------- |
| agl | agl@chromium.org changed reviewers: + rch@chromium.org | 6 years, 1 month ago (2014-11-03 22:09:21 UTC)#4 |
|---|
| agl | +rch, randomly, because rsleevi is away and because the most questionable part is the Finch ... | 6 years, 1 month ago (2014-11-03 22:09:22 UTC)#5 |
|---|
| Ryan Hamilton | If you're paranoid, you can run with -force-fieldtrials=SSLv3/Enabled/ to ensure that your code does what ... | 6 years, 1 month ago (2014-11-03 23:02:52 UTC)#6 |
|---|
| agl | https://codereview.chromium.org/693963003/diff/20001/chrome/browser/net/ssl\_config\_service\_manager\_pref.cc File chrome/browser/net/ssl_config_service_manager_pref.cc (right): https://codereview.chromium.org/693963003/diff/20001/chrome/browser/net/ssl\_config\_service\_manager\_pref.cc#newcode279 chrome/browser/net/ssl_config_service_manager_pref.cc:279: base::FieldTrialList::FindFullName("SSLv3"); On 2014/11/03 23:02:52, Ryan Hamilton wrote: > Nit: ... | 6 years, 1 month ago (2014-11-04 19:00:32 UTC)#7 |
|---|
| agl | The CQ bit was checked by agl@chromium.org | 6 years, 1 month ago (2014-11-04 19:00:35 UTC)#8 |
|---|
| commit-bot: I haz the power | CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693963003/40001 | 6 years, 1 month ago (2014-11-04 19:02:43 UTC)#9 |
|---|
| agl | The CQ bit was unchecked by agl@chromium.org | 6 years, 1 month ago (2014-11-04 19:11:09 UTC)#10 |
|---|
| agl | The CQ bit was checked by agl@chromium.org | 6 years, 1 month ago (2014-11-04 19:12:52 UTC)#11 |
|---|
| commit-bot: I haz the power | CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693963003/60001 | 6 years, 1 month ago (2014-11-04 19:14:32 UTC)#12 |
|---|
| commit-bot: I haz the power | The CQ bit was unchecked by commit-bot@chromium.org | 6 years, 1 month ago (2014-11-04 19:39:56 UTC)#13 |
|---|
| commit-bot: I haz the power | Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux\_gpu\_triggered\_tests/builds/76296) | 6 years, 1 month ago (2014-11-04 19:39:56 UTC)#14 |
|---|
| agl | The CQ bit was checked by agl@chromium.org | 6 years, 1 month ago (2014-11-04 19:41:04 UTC)#15 |
|---|
| commit-bot: I haz the power | CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693963003/80001 | 6 years, 1 month ago (2014-11-04 19:42:09 UTC)#16 |
|---|
| commit-bot: I haz the power | The CQ bit was unchecked by commit-bot@chromium.org | 6 years, 1 month ago (2014-11-04 20:06:15 UTC)#17 |
|---|
| commit-bot: I haz the power | Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux\_gpu\_triggered\_tests/builds/76313) | 6 years, 1 month ago (2014-11-04 20:06:16 UTC)#18 |
|---|
| agl | The CQ bit was checked by agl@chromium.org | 6 years, 1 month ago (2014-11-05 03:14:40 UTC)#19 |
|---|
| commit-bot: I haz the power | CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693963003/50007 | 6 years, 1 month ago (2014-11-05 03:15:53 UTC)#20 |
|---|
| commit-bot: I haz the power | Committed patchset #6 (id:50007) | 6 years, 1 month ago (2014-11-05 04:17:14 UTC)#21 |
|---|
| commit-bot: I haz the power | Patchset 6 (id:??) landed as https://crrev.com/0a4a16346d0a921949ad8f423934350a3b504e70 Cr-Commit-Position: refs/heads/master@{#302754} | 6 years, 1 month ago (2014-11-05 04🔞08 UTC)#22 |
|---|