#42454 (Unable to translate codex URL in theme-editor.php) – WordPress Trac (original) (raw)

#1 @dd32

Keywords has-patch needs-refresh i18n-change added
Milestone changed from Awaiting Review to 4.9.1

Thanks for reporting @odysseygate!

You're right, this URL should probably be translated, however the patch should probably be esc_url( __() ) instead (That can be changed upon commit if needed)

This would be an additional string, the Child_Themes URL isn't translated anywhere else.

Marking as 4.9.1, although this is small enough to slip into 4.9 if so desired ( @melchoyce ) -

#7 @dd32

8 years ago

Owner set to dd32
Resolution set to fixed
Status changed from new to closed

In [42247](/changeset/42247 "Theme Editor: Translate the URL to the Child Themes Codex page.

Props ..."):

Theme Editor: Translate the URL to the Child Themes Codex page.

Props odysseygate, johnpgreen.
Fixes #42454.

#8 @dd32

8 years ago

Keywords i18n-change removed
Milestone changed from 4.9.2 to 4.9.1

I completely missed that this string was already translated (I only checked the admin text domain, not the global text domain). Lets push this out.

#9 @dd32

8 years ago

In [42248](/changeset/42248 "Theme Editor: Translate the URL to the Child Themes Codex page.

Props ..."):

Theme Editor: Translate the URL to the Child Themes Codex page.

Props odysseygate, johnpgreen.
Merges [[42247]](/changeset/42247 "Theme Editor: Translate the URL to the Child Themes Codex page.

Props ...") to the 4.9 branch.
Fixes #42454.