Issue 2753: Optional's constructors and assignments need constraints (original) (raw)

This page is a snapshot from the LWG issues list, see the Library Active Issues List for more information and the meaning of Resolved status.

2753. Optional's constructors and assignments need constraints

Section: 22.5.3.2 [optional.ctor], 22.5.3.4 [optional.assign] Status: Resolved Submitter: Casey Carter Opened: 2016-07-22 Last modified: 2017-06-15

Priority: 0

View all other issues in [optional.ctor].

View all issues with Resolved status.

Discussion:

To use optional<T> as if it were a T in generic contexts, optional<T>'s "generic" operations must behave as do those of T under overload resolution. At minimum, optional's constructors and assignment operators should not participate in overload resolution with argument types that cannot be used to construct/assign the contained T so that is_constructible_v<optional<T>, Args...>(respectively is_assignable_v<optional<T>&, RHS>) is equivalent to is_constructible_v<T, Args...> (respectively is_assignable_v<T&, RHS>).

In passing, note that the Requires element for optional's in-place initializer_list constructor unnecessarily duplicates its Remarks element; it should be removed.

It should also be noted that the resolution of LWG 2451(i) adds constructors to optional with appropriate constraints, but does not constrain the additional assignment operators. If LWG chooses to apply the resolution of 2451 to the WP, the Requires elements of the additional assignment operators should also be converted to constraints as the wording herein does for the assignment operators in N4606.

[2016-07 Chicago]

Monday: P0 - tentatively ready

[2016-11-28 Post-Issaquah]

Resolved by the adoption of 2756(i)

Proposed resolution:

This wording is relative to N4606.

  1. Remove [optional.object.ctor] p3, and add a new paragraph after p6:

    optional(const optional& rhs);

    -3- Requires: is_copy_constructible_v<T> is true.

    […]

    -?- Remarks: The function shall not participate in overload resolution unless is_copy_constructible_v<T> is true.

  2. Remove [optional.object.ctor] p7, and change p11 to:

    optional(optional&& rhs) noexcept(see below);

    -7- Requires: is_move_constructible_v<T> is true.

    […]

    -11- Remarks: The expression inside noexcept is equivalent to is_nothrow_move_constructible_v<T>. The function shall not participate in overload resolution unless is_move_constructible_v<T> is true.

  3. Remove [optional.object.ctor] p12, and change p16 to:

    constexpr optional(const T& v);

    -12- Requires: is_copy_constructible_v<T> is true.

    […]

    -16- Remarks: If T's selected constructor is a constexpr constructor, this constructor shall be a constexpr constructor. The function shall not participate in overload resolution unless is_copy_constructible_v<T> is true.

  4. Remove [optional.object.ctor] p17, and change p21 to:

    constexpr optional(T&& v);

    -17- Requires: is_move_constructible_v<T> is true.

    […]

    -21- Remarks: If T's selected constructor is a constexpr constructor, this constructor shall be a constexpr constructor. The function shall not participate in overload resolution unless is_move_constructible_v<T> is true.

  5. Remove [optional.object.ctor] p22, and change p26 to:

    template <class... Args>
    constexpr explicit optional(in_place_t, Args&&... args);

    -22- Requires: is_constructible_v<T, Args&&...> is true.

    […]

    -26- Remarks: If T's constructor selected for the initialization is a constexpr constructor, this constructor shall be a constexpr constructor. The function shall not participate in overload resolution unless is_constructible_v<T, Args...> is true.

  6. Remove [optional.object.ctor] p27.

    template <class U, class... Args>
    constexpr explicit optional(in_place_t, initializer_list il, Args&&... args);

    -27- Requires: is_constructible_v<T, initializer_list<U>&, Args&&...> is true.

    […]

  7. Remove [optional.object.assign] p4, and change p8 to:

    optional& operator=(const optional& rhs);

    -4- Requires: is_copy_constructible_v<T> is true and is_copy_assignable_v<T> is true.

    […]

    -8- Remarks: If any exception is thrown, the result of the expression bool(*this) remains unchanged. If an exception is thrown during the call to T's copy constructor, no effect. If an exception is thrown during the call to T's copy assignment, the state of its contained value is as defined by the exception safety guarantee of T's copy assignment. The function shall not participate in overload resolution unless is_copy_constructible_v<T> && is_copy_assignable_v<T> is true.

  8. Remove [optional.object.assign] p9, and add a new paragraph after p14:

    optional& operator=(optional&& rhs) noexcept(see below);

    -9- Requires: is_move_constructible_v<T> is true and is_move_assignable_v<T> is true.

    […]

    -14- Remarks: […] If an exception is thrown during the call to T's move assignment, the state of *val and *rhs.val is determined by the exception safety guarantee of T's move assignment.

    The function shall not participate in overload resolution unless is_move_constructible_v<T> && is_move_assignable_v<T> is true.

  9. Remove [optional.object.assign] p15, and change p19 to (yes, this wording is odd - the intent is that it will "do the right thing" after incorporation of LWG 2451(i)):

    template optional& operator=(U&& v);

    -15- Requires: is_constructible_v<T, U> is true and is_assignable_v<T&, U> is true.

    […]

    -19- Remarks: If any exception is thrown, the result of the expression bool(*this) remains unchanged. If an exception is thrown during the call to T's constructor, the state of v is determined by the exception safety guarantee of T's constructor. If an exception is thrown during the call to T's assignment, the state of *val and v is determined by the exception safety guarantee of T's assignment. The function shall not participate in overload resolution unless is_same_v<decay_t<U>, T> && is_constructible_v<T, U> && is_assignable_v<T&, U> is true.